fix(compiler-core): preserve whitespace around interpolations (fix #7542) - #15168
Draft
fengnovo wants to merge 1 commit into
Draft
fix(compiler-core): preserve whitespace around interpolations (fix #7542)#15168fengnovo wants to merge 1 commit into
fengnovo wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve condensed boundary whitespace when an interpolation is the first or last child of a non-root element.
This makes interpolated content consistent with static text in inline markup. For example:
now renders with the source whitespace between
Fooand the interpolated value instead of collapsing the output toFooBar.Root cause
condenseWhitespace()unconditionally removed all-whitespace text nodes at the start and end of every child list. That also removed whitespace adjacent to an interpolation, even though equivalent static text preserves a condensed space.The parser now distinguishes root-level whitespace from element boundary whitespace. In the default
condensemode, it keeps a single boundary space next to an interpolation inside an element. Root-level behavior andwhitespace: 'preserve'behavior remain unchanged.Tests
whitespace: 'preserve'../node_modules/.bin/vitest --project 'unit*' run./node_modules/.bin/tsc --incremental --noEmitFixes #7542