Repository navigation
Conversation
Use the shared Commonlib reflection result contract at the receiver and CLI boundaries. Register the recovery probe observer before releasing layout-ready callbacks so late subscription cannot leave the test waiting for a completed safety scan.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix restores unavailable local database access before synchronisation resumes and retains incomplete ordinary-file reflection for a bounded retry after its required resources recover.
Related to #1360 and #1224.
Dependency and draft status
Depends on Commonlib #225, revision
696e31bac449e5531242855bffa45080090df16e. This PR remains draft until a published package containing that change is pinned exactly in the dependency manifest and lockfile and consumer validation passes with that package.The manifest and lockfile still select registry Commonlib 0.5.0, which lacks the required APIs. Local validation used a combined unpublished package with tarball SHA-256
4b2e0122514c925ba54bf2a85c3277e31b4d74fc30cc5f58029c3de31879e542. Its package contents were checked byte-for-byte in the locked dependency tree, preserving transitive versions. A plainnpm cidoes not reproduce this candidate. Existing PR test workflows skip drafts.Behaviour
local-databaseandremotedependencies must all recover before consuming and saving one automatic allowance per revision. Unknown failures and unsuccessful retries remain available for review. Same-database reopening preserves pending records and consumed allowances.Validation
npm run checkpassed: main/application types, lint, Svelte, production build, and iOS 15 syntax compatibility. The full unit suite passed with 220 files / 2,383 tests passed and 2 skipped. Existing warnings remain.Tested plug-in bundle SHA-256:
0b5d08b170e54047c762a7d6142405bd771bbcb970c7cb3b380e1d392518ff7c.For controlled receiver verification with the matching package installed, run
npm run test:e2e:obsidian:focused -- database-recoverywith a discoverable Obsidian executable. Build the Commonlib package withnpm run build:packageand pack the generated.packagedirectory, rather than the repository root.Remaining verification
Earlier iPhone diagnostics reproduced repeated fixture
InvalidStateErrorafter explicit native closure. A same-name Pouch reused the stale connection; explicit close/reopen preserved the fixture content and revision. Natural iOS/WebKit connection termination was not reproduced in the successful baseline runs, and this integrated recovery candidate still needs physical iPhone verification. Linux WebKit diagnostics could not start because shared libraries were missing.The implemented contracts and verification boundaries are recorded in local database recovery, file reflection recovery, and Review Harness diagnostics.