Skip to content

feat: mute version notices for individual devices - #1357

Open
vrtmrz wants to merge 1 commit into
mainfrom
feat/device-local-version-notices
Open

vrtmrz wants to merge 1 commit into
mainfrom
feat/device-local-version-notices

Conversation

@vrtmrz

@vrtmrz vrtmrz commented Nov 15, 2026

Copy link
Copy Markdown
Owner

This improvement lets users mute recurring plug-in version Notices for individual devices from Joined devices, with the choices retained locally across restarts.

  • Add Mute version notices and Unmute version notices to each other device’s row. Exclude selected device IDs from advisory newer- and older-version Notices while retaining notifications for unmuted devices, including those running the same version.
  • Save the choices through the existing device-local config store, scoped by Vault name and database suffix. Synchronisation compatibility checks remain enabled.
  • Move device removal into the … menu as Forget device record…, retaining the confirmation and cancellation flow. Keep the primary actions on one row in the tested mobile viewport.
  • Update the English fallback messages, settings reference, glossary, change notes, unit tests, and real Obsidian E2E scenario.

Related: #1349. The existing Notice expired after approximately 15 seconds in desktop and mobile-emulation observations; the reporter’s indefinite-visibility scenario was not reproduced. This change addresses repeated notifications across sessions by adding a persistent opt-out per device.

Validation:

  • npm run check, production build, and iOS 15 syntax compatibility passed. Focused checks and the build also passed after the final UI adjustments.
  • All 44 related unit tests passed, covering independent device choices, another device using the same version, persistence, restoring Notices, storage failures, and cancellation.
  • Real Obsidian E2E passed with CouchDB: independent mute/unmute, persistence across a full process restart, desktop/mobile menus, Escape, removal confirmation/cancellation, and preservation of other remote device records. Mobile checks used 390 × 844 emulation, not a physical device. Object Storage E2E was not run.
  • The mobile action-row regression failed before the layout fix and passed afterwards. git diff --check passed. The committed patch matches the final validated patch exactly; those results were reused for the final review.

The full unit suite was not green: the earlier run passed 2,265 tests, skipped two, and failed one CLI 400-file watcher case. The final related-test run also reproduced that CLI failure, while the unchanged baseline passed in separate runs. Its cause remains unconfirmed for this worktree; CLI watcher production code and tests are unchanged by this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant