Repository navigation
Fix Simulator request interception during application startup - #23
Merged
Merged
Conversation
Context-wide interception can miss an application target that is still initializing over CDP. Wait for the exact application target before installing fixture routing and reloading it. Add a delayed-interception regression test that reproduces the failed main CI request.
Coverage Report for Application
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Simulator fixture could enable request interception while the application target was still initializing. Playwright then missed that target. After the tested reload, GraphQL bypassed the local fixture and failed against the blocked network. Home displayed
Error: Failed to fetch, as in the failed main CI run.Wait for the exact application target before installing interception:
Add a regression scenario that delays interception by 500 ms. It checks fixture content and native ArrowRight navigation in the real Simulator. Update the contribution guide with the required startup order.
Evidence
ERR_PROXY_CONNECTION_FAILED.After: The same timing reproduction passed three times after the target wait moved before interception.
yarn verifypasses TypeScript, FSD, both Knip modes, unit coverage, the production build, Chromium, and Chrome 68.Risk
The change affects Simulator startup and one new regression scenario. Initial requests remain blocked while CDP connects. The tested reload starts after fixture interception is active.