Repository navigation
Introduce TypeScript, FSD, coverage bot, and required LG Simulator CI - #19
Merged
Merged
Conversation
Collaborator
|
Nicely done. I had a similar idea adding more tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app uses strict TypeScript and Feature-Sliced Design. Knip checks unused code. Vitest requires at least 95% statements, branches, functions, and lines. A pinned coverage bot reports the results on pull requests.
The Simulator job runs on Ubuntu 24.04 with Xvfb at 1920×1080. It verifies the pinned webOS TV 26 Simulator 1.5.0 archive before use. Tests select the application target through CDP, send native navigation keys, intercept requests with local fixtures, isolate storage, and preserve storage during restart tests. Reports remain available for 14 days. Cleanup stops the Simulator process group.
CONTRIBUTING.mdexplains TypeScript, FSD, tests, coverage, translations, Simulator setup, and deployment. The README contains new 1920×1080 screenshots and an automatic contributor widget. The Homebrew listing uses the same screenshot files frommain. The package author isvolkovmqx.Review fixes remove duplicate player state and the
Rootwrapper. Search results and stored talks now use one validator. Invalid saved entries cannot crash the UI. Valid older talks with nullable descriptions remain supported. The Docker image path now matches the documentedghcr.io/volkovmqx/cccbibpath.Evidence
description: null. Regression tests cover malformed search results, corrupt saved data, and nullable descriptions.GitHub requires
quality / webos-simulatorandquality / qualitybefore merges tomain, including administrator merges. The branch must be up to date.Risk
The migration changes application imports and screen composition. Storage keys and formats remain unchanged. Simulator tests do not verify TV hardware decoders or real webOS services. No release or Docker image was published.