Repository navigation
fix(vikingdb-memory): stop printing to stdout in the stdio MCP server - #448
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
The tools used print() for responses and errors. With the default stdio transport, stdout carries the JSON-RPC stream, so any print corrupts the protocol. Use the module logger (stderr) instead, and add a regression test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Start review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stdout pollution in the VikingDB memory MCP server (no issue filed).
Cause.
add_memoriesandsearch_memorycallprint()for service responses and errors. The server defaults to the stdio transport, where stdout carries the JSON-RPC stream, so every tool call writes non-protocol text into it and can break the client's parsing.Fix. Replace the
print()calls with the modulelogger(the existinglogging.basicConfigwrites to stderr): responses at info, errors at error.Test.
tests/test_stdout_clean.pycalls both tools (success and failure paths, with the service stubbed offline) and asserts nothing reaches stdout. It fails on main and passes with the change.Not changed:
MEMORY_REGIONis read into the config but never passed toVikingDBMemoryService; its default (cn-north-1) differs from the service's own default (cn-beijing), so wiring it would change behavior and is left for the maintainers.This change was prepared with the assistance of an AI coding tool (Claude Code).