Repository navigation
[release-1.14] Correct NominatedNodeName lifecycle and preempt eligibility - #6090
Merged
volcano-sh-bot merged 2 commits intoOct 14, 2026
Merged
volcano-sh-bot merged 2 commits into
volcano-sh-bot merged 2 commits into
Conversation
volcano-sh-bot
added
do-not-merge/work-in-progress
… fixes Co-authored-by: JesseStutler <38534065+JesseStutler@users.noreply.github.com>
volcano-sh-bot
added
size/L
Copilot
AI
changed the title
[WIP] Fix NominatedNodeName lifecycle and preempt eligibility
[release-1.14] Correct NominatedNodeName lifecycle and preempt eligibility
Oct 13, 2026
JesseStutler
marked this pull request as ready for review
October 13, 2026 13:46
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The backport preserves the upstream behavior and includes focused regression coverage for all affected paths.
0 open findings
What changed in this PR
Backports #6066 to fix scheduler nomination lifecycle and preemption eligibility.
Changes:
- Prevents stale nominations after rollback while retaining committed nominations.
- Corrects nominated-node preemption checks and ordering.
- Adds regression coverage for lifecycle and eligibility scenarios.
| File | Description |
|---|---|
pkg/scheduler/util/test_utils.go |
Adds nominated-node pod test helper. |
pkg/scheduler/framework/statement.go |
Clears live eviction state on rollback. |
pkg/scheduler/framework/statement_nomination_test.go |
Tests pipeline lifecycle behavior. |
pkg/scheduler/api/job_info.go |
Derives nominations from live state. |
pkg/scheduler/api/job_info_test.go |
Tests nomination derivation. |
pkg/scheduler/actions/preempt/preempt.go |
Corrects preemption eligibility flow. |
pkg/scheduler/actions/preempt/preempt_test.go |
Covers schedulable and deleted nominations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6066 to release-1.14, resolving conflicts while preserving release-specific behavior. Addresses stale nominations after rollback and incorrectly blocked preemption.
EvictionOccurredon rollback; retain nominations after committed preemption.PrePredicateFn; evaluate nominated-node predicates afterward. Allow schedulable or deleted nominated nodes without bypassing the terminating-victim guard.