Repository navigation
[release-1.13] fix(scheduler): latch PodGroup Completed phase to prevent quota re-reservation after Pods deleted - #6056
Merged
volcano-sh-bot merged 2 commits intoOct 7, 2026
Conversation
…servation after Pods deleted Once a PodGroup reaches Completed, deleting its finished member Pods (TTL/GC/workload controller) caused getPodGroupPhase to recompute from an empty TaskStatusIndex and downgrade the phase back to Pending, after which the enqueue action re-admitted it to Inqueue and the capacity/proportion plugins reserved its MinResources queue quota again. Latch the Completed phase when all member tasks are gone so the dead group can never re-enter the queue. Fixes part of volcano-sh#4195 Signed-off-by: yuanhuaiwang <yuanhuaiwang@users.noreply.github.com>
…minal Address review feedback in volcano-sh#5996: pod deletion is not atomic and usually spans multiple scheduler sessions, so the previous latch (only when all tasks were removed) did not cover a partially deleted group, which was still downgraded to Pending/Inqueue and re-reserved its MinResources quota. Latch the phase whenever the PodGroup is Completed and every remaining task is in a terminal state (Succeeded/Failed); the empty-task case is subsumed since the loop passes vacuously. Any remaining non-completed task still falls through to the normal recompute. Add regression tests for the partially deleted and failed-task cases. Signed-off-by: huaiwang.yuan <huaiwang.yuan@transsion.com>
3 tasks done
volcano-sh-bot
added
the
size/M
Member
|
/lgtm |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hajnalmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
volcano-sh-bot
merged commit Oct 7, 2026
b8abf6f
into
volcano-sh:release-1.13
16 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5996