Repository navigation
[release-1.14] cli: reject invalid output formats in describe commands - #6051
Merged
volcano-sh-bot merged 1 commit intoOct 7, 2026
Conversation
vcctl jobflow describe and vcctl jobtemplate describe printed "Unsupported format: <value>" for any -o value other than json or yaml and then returned nil, so the command exited 0. Scripts that redirect the output to a file kept the message as the file contents and carried on, because the exit status said the command had worked. The format is now checked before the apiserver call and an unsupported value returns an error, so the command exits non-zero and says what the valid formats are. The printers return their marshal errors for the same reason instead of printing them and returning as if nothing was wrong. Signed-off-by: iamtanishqjain <tanishqjain7014@gmail.com>
volcano-sh-bot
added
the
size/L
Member
|
/retest |
Member
|
/lgtm |
volcano-sh-bot
added
kind/bug
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hajnalmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
volcano-sh-bot
merged commit Oct 7, 2026
6acda05
into
volcano-sh:release-1.14
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6012