Repository navigation
[ci-selector] Write CUDA kernel names at launch so recordings no longer need the exit footer - #914
Merged
Merged
Conversation
…o footer Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
…r check Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
tahsintunan
requested review from
AndreasKaratzas and
khluu
and removed request for
khluu
November 15, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# endfooter at normal exit. Many processes never get there: vLLM kills the engine process 5 s into shutdown, and forked children leave throughos._exit, which skips the code that writes the footer. One such process makes its whole step unusable, so only about half the CUDA rows can be used (130 of 250 on nightly #102399).sync=1.kernel_table.pyaccepts async=1file without a footer, as long as it has no error lines. Older files and ROCm files keep the footer rule.