Skip to content

[ci-selector] Stop always picking AMD jobs that set automatic_shard - #913

Merged
AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
tahsintunan:fix/ci-selector-amd-automatic-shard
Nov 14, 2026
Merged

AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
tahsintunan:fix/ci-selector-amd-automatic-shard

Conversation

@tahsintunan

Copy link
Copy Markdown
Collaborator

Summary

  • AMD jobs can set automatic_shard in their mirror: amd: block. The selector didn't know this setting, and it picks every job that has a setting it doesn't know, just in case. So about 200 AMD jobs were picked on every PR, whatever the PR changed. On a PR that changes one test file, this change cuts the AMD jobs picked from 207 to 3, and the NVIDIA jobs picked stay exactly the same.
  • automatic_shard only splits a job into smaller parallel jobs. It never decides whether the job runs or which tests it runs. So the selector can safely ignore it. Settings it really doesn't know still make it pick the job.
  • The selector ignores AMD jobs in production today, so CI didn't change. This matters as soon as AMD jobs start using the selector.
  • One existing test failed on Mac only. A search pattern used \b, which Mac's git grep doesn't support. I switched to a form that works on both Mac and Linux.

Notes

  • Second commit only changes formatting. test_classify.py didn't pass the repo's ruff checks on main. That commit runs the formatter and renames a variable called l. It changes no behavior.

…_shard, and make the relative-import grep work on macOS

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
@tahsintunan
tahsintunan requested a review from khluu November 14, 2026 01:02
@AndreasKaratzas
AndreasKaratzas merged commit 1b5e4d9 into vllm-project:main Nov 14, 2026
2 checks passed
@tahsintunan
tahsintunan deleted the fix/ci-selector-amd-automatic-shard branch November 14, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants