Repository navigation
[ci-selector] Stop always picking AMD jobs that set automatic_shard - #913
Merged
AndreasKaratzas merged 2 commits intoNov 14, 2026
Merged
AndreasKaratzas merged 2 commits into
AndreasKaratzas merged 2 commits into
Conversation
…_shard, and make the relative-import grep work on macOS Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
automatic_shardin theirmirror: amd:block. The selector didn't know this setting, and it picks every job that has a setting it doesn't know, just in case. So about 200 AMD jobs were picked on every PR, whatever the PR changed. On a PR that changes one test file, this change cuts the AMD jobs picked from 207 to 3, and the NVIDIA jobs picked stay exactly the same.automatic_shardonly splits a job into smaller parallel jobs. It never decides whether the job runs or which tests it runs. So the selector can safely ignore it. Settings it really doesn't know still make it pick the job.\b, which Mac'sgit grepdoesn't support. I switched to a form that works on both Mac and Linux.Notes
test_classify.pydidn't pass the repo's ruff checks on main. That commit runs the formatter and renames a variable calledl. It changes no behavior.