Repository navigation
[pipeline-generator] Find the tracing helpers in the CPU test image - #908
Merged
Merged
Conversation
The tracing setup looks for the ci-otel helpers through the git checkout, then through BUILDKITE_BUILD_CHECKOUT_PATH. The CPU test image has no .git, and the docker plugin passes no checkout path into the container, so on CPU docker-plugin steps both lookups fail, the job logs "tracing setup skipped", and main records no per-test timings for them. Fall back to the image's own copy under /vllm-workspace. Steps where either earlier lookup works are unchanged, and PR builds render the same pipeline as before. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Thangnguyenvn98
force-pushed
the
agent/otel-cpu-image-fallback
branch
from
November 13, 2026 16:56
52896fa to
32b7dcd
Compare
6 tasks done
Thangnguyenvn98
marked this pull request as ready for review
November 13, 2026 18:37
6 tasks done
Collaborator
Author
Validation builds: tracing and timings on the CPU steps with this branch's generatorTwo builds on the tracing treatment branch, each with
All four jobs passed with no retries.
Not covered: the other CPU docker-plugin steps (same image and setup line), and the agent slots after the builds. The helpers write only to the container's temp directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trunk change: needs line-by-line review (the pipeline generator's tracing setup, which runs in every traced job on main).
Summary
The CPU steps that the generator launches through the docker plugin record no per-test timings on main. Their logs say
vLLM CI OTel: tracing setup skipped. The setup finds the tracing helpers through the git checkout, then throughBUILDKITE_BUILD_CHECKOUT_PATH; the CPU test image has no.git, and the docker plugin passes no checkout path into the container, so both lookups fail. This has been the case since #480 moved the helpers into the vLLM checkout.After this change the setup falls back to the copy the image already carries under
/vllm-workspace. Without timings, these steps can't be enrolled in automatic sharding: the planner has nothing to plan from.Decisions to check
BUILDKITE_BUILD_CHECKOUT_PATHexpansion. Passing the checkout path into the container was the alternative; it names a host path the container can't see.CI_INFRA_OTEL_DIRin the CPU Dockerfile would also work, but it needs an image rebuild, only helps commits built after it, and puts a CI path into each image that lacks.git. Copying.gitinto the image would add hundreds of MB to every CPU job's pull.What changed
Not done
cpu-tool-parsers). The other CPU docker-plugin steps use the same image and setup line, and get their first timings from main after merge.Testing
python -m pytest buildkite/tests: 614 passed on the rebased commit. New test: with no git checkout and no checkout path, the setup loads the helper from the image workspace.cpu-tool-parsers(https://buildkite.com/vllm/ci/builds/102535): passed with no retries. The job no longer logstracing setup skipped; its tests match main (1501 passed, 1 skipped, 30 xfailed); and the timings service now answers for the step with 43 files whose times sum to the pytest run time, under the file names the planner uses. It had no timings for this step before.AI assistance
Written with Claude Code. Not yet reviewed line by line by a human.
🤖 Generated with Claude Code