Repository navigation
Suppress determinism rules inside Workflow.sideEffect callbacks - #1
Merged
Merged
Conversation
Temporal executes a Workflow.sideEffect(...)/mutableSideEffect(...) callback exactly once and replays its recorded result, so calls that are otherwise determinism violations (UUID.randomUUID(), Math.random(), the various Random APIs, non-deterministic time reads) are safe there. Introduce ExecutionContext and ContextEntryPoint so CallGraphAnalyzer can attribute each call-graph match to the context it was found in, teach forbidden-method rules to declare which contexts they're suppressed in via a new suppressedContexts field, and mark WG001/WG003/WG004/WG005/WG006/WG007 as suppressed in SIDE_EFFECT. Extend sample-temporal-project with calls to UUID.randomUUID() and Workflow.newRandom().nextInt() from inside Workflow.sideEffect(...), verifying the suppression end-to-end: the violation count stays at 12 even though the new call sites would otherwise trigger WG001/WG005. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporal executes a Workflow.sideEffect(...)/mutableSideEffect(...) callback exactly once and replays its recorded result, so calls that are otherwise determinism violations (UUID.randomUUID(), Math.random(), the various Random APIs, non-deterministic time reads) are safe there. Introduce ExecutionContext and ContextEntryPoint so CallGraphAnalyzer can attribute each call-graph match to the context it was found in, teach forbidden-method rules to declare which contexts they're suppressed in via a new suppressedContexts field, and mark WG001/WG003/WG004/WG005/WG006/WG007 as suppressed in SIDE_EFFECT.
Extend sample-temporal-project with calls to UUID.randomUUID() and Workflow.newRandom().nextInt() from inside Workflow.sideEffect(...), verifying the suppression end-to-end: the violation count stays at 12 even though the new call sites would otherwise trigger WG001/WG005.