Skip to content

Deflake Dual-channel full sync with compression delivers writes made during load test #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PoisonGodv wants to merge 5 commits into
base: unstable
Choose a base branch
from
Open

Deflake Dual-channel full sync with compression delivers writes made during load test #5076

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bc5dbb
Deflake Dual-channel full sync with compression delivers writes made …
PoisonGodv Oct 28, 2026
570fd68
Hold replica load open in dual-channel compression tests
PoisonGodv Oct 29, 2026
3c0fffa
Remove pipelining from dual-channel load test
PoisonGodv Oct 29, 2026
3a47a30
Merge branch 'unstable' into fix-5003-dual-channel-compression
PoisonGodv Nov 6, 2026
c851353
Merge branch 'unstable' into fix-5003-dual-channel-compression
PoisonGodv Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/integration/repl-compression.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,10 @@ start_server {tags {"repl"} overrides {save ""}} {

start_server {overrides {save "" repl-compression lz4 dual-channel-replication-enabled yes}} {
set replica [srv 0 client]
# Hold the RDB load open until the in-load assertions below.
# Process events often enough to answer INFO and CONFIG SET.
$replica config set key-load-delay 10000
$replica config set loading-process-events-interval-bytes 1024
$replica replicaof $primary_host $primary_port

# rdb-key-save-delay stretches the RDB stage; catch the sync window.
Expand All @@ -1160,6 +1164,7 @@ start_server {tags {"repl"} overrides {save ""}} {
$primary set during_load:large $during_load_payload
assert_equal 1 [s 0 master_sync_in_progress]
assert_match {*state=bg_transfer*repl_compression=lz4*} [$primary info replication]
$replica config set key-load-delay 0

wait_for_condition 200 100 {
[s 0 master_link_status] eq {up}
Expand Down Expand Up @@ -1266,6 +1271,10 @@ start_server {tags {"repl"} overrides {save ""}} {

start_server [list overrides [list save "" repl-compression $replica_mode dual-channel-replication-enabled yes]] {
set replica [srv 0 client]
# Hold the RDB load open until the in-load assertions below.
# Process events often enough to answer INFO and CONFIG SET.
$replica config set key-load-delay 10000
$replica config set loading-process-events-interval-bytes 1024
$replica replicaof $primary_host $primary_port

wait_for_condition 500 10 {
Expand All @@ -1288,6 +1297,7 @@ start_server {tags {"repl"} overrides {save ""}} {
assert_match {*state=bg_transfer*} [$primary info replication]
assert_equal $initial_compressed \
[regexp -all {repl_compression=(lz4|zstd)} [$primary info replication]]
$replica config set key-load-delay 0

wait_for_condition 200 100 {
[status $primary sync_partial_ok] == $partial_before + 1 &&
Expand Down
Loading