Repository navigation
Conversation
Signed-off-by: Alex Le <alex.le@improving.com>
Signed-off-by: Alex Le <alex.le@improving.com>
currantw
reviewed
Sep 28, 2026
| ) | ||
| client = None | ||
|
|
||
| try: |
Collaborator
There was a problem hiding this comment.
Is the try/catch block really needed for an example? Could we just have the happy path, so readers focus on the string operations? Do other Python examples also include try/catch every time we create/use/close a client?
| require "valkey" | ||
|
|
||
| client = Valkey.new(host: "localhost", port: 6379) | ||
| client = nil |
Collaborator
There was a problem hiding this comment.
Is this needed? Not sure about Ruby syntax, but could we just declare in begin?
Comment on lines
+233
to
+234
| rescue StandardError => e | ||
| puts "Operation failed: #{e.message}" |
Collaborator
There was a problem hiding this comment.
Similar to previous comment, is this necessary in a basic operations example? Or can we just assume the client gets created successfully?
yipin-chen
approved these changes
Oct 2, 2026
5 of 6 tasks
Collaborator
|
Is this replaced mostly by #370? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the outdated Python client-construction pattern reported in #326 and correct equivalent issues found while auditing the other language examples.
Issues
Closes #326
Changes
GlideClientConfigurationandawait GlideClient.create(...)GlideClient.createClient(...)callsValidation
pnpm buildgit diff --check