Allow contributor copyright notices in RuboCop - #12504
Conversation
|
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/12504/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
60b8521 to
4fc7cae
Compare
Accept copyright notices from any holder instead of requiring SUSE LLC, so external contributors can retain accurate attribution. Signed-off-by: Akash Kumar <91385321+AkashKumar7902@users.noreply.github.com>
4fc7cae to
975e443
Compare
What does this PR change?
Broadens the testsuite RuboCop copyright rule to accept notices from any copyright holder instead of requiring
SUSE LLC.The copyright cop remains enabled and the existing SUSE autocorrect template is unchanged. This allows contributor-owned files to keep accurate attribution and unblocks the RuboCop checks on #12077 and #12341.
End-User Impact & Release Notes
No end-user impact. This only changes testsuite lint configuration.
Codespace
GUI diff
No difference.
Documentation
No documentation needed: only internal and user-invisible lint configuration changes.
DONE
Test coverage
RuboCop 1.82.1 passes on all testsuite Ruby files scanned by the workflow.
A contributor-owned copyright notice passes.
A Ruby file without a copyright notice is still rejected by
Style/Copyright.DONE
Links
Issue(s): none
Related PRs: #12077, #12341
Port(s): none
Changelogs
Re-run a test
Before you merge
Check How to branch and merge properly!