Skip to content

Allow contributor copyright notices in RuboCop - #12504

Merged
cbosdo merged 1 commit into
uyuni-project:masterfrom
AkashKumar7902:fix/rubocop-copyright-notice
Aug 28, 2026
Merged

cbosdo merged 1 commit into
uyuni-project:masterfrom
AkashKumar7902:fix/rubocop-copyright-notice

Conversation

@AkashKumar7902

Copy link
Copy Markdown
Contributor

What does this PR change?

Broadens the testsuite RuboCop copyright rule to accept notices from any copyright holder instead of requiring SUSE LLC.

The copyright cop remains enabled and the existing SUSE autocorrect template is unchanged. This allows contributor-owned files to keep accurate attribution and unblocks the RuboCop checks on #12077 and #12341.

End-User Impact & Release Notes

No end-user impact. This only changes testsuite lint configuration.

  • DONE

Codespace

Create CodeSpace

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user-invisible lint configuration changes.

  • DONE

Test coverage

  • RuboCop 1.82.1 passes on all testsuite Ruby files scanned by the workflow.

  • A contributor-owned copyright notice passes.

  • A Ruby file without a copyright notice is still rejected by Style/Copyright.

  • DONE

Links

Issue(s): none
Related PRs: #12077, #12341
Port(s): none

  • DONE

Changelogs

  • No changelog needed

Re-run a test

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "frontend_checks"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@AkashKumar7902
AkashKumar7902 requested a review from a team as a code owner August 26, 2026 08:53
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (approx. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/12504/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/12504/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!

@cbosdo cbosdo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkashKumar7902
AkashKumar7902 force-pushed the fix/rubocop-copyright-notice branch from 60b8521 to 4fc7cae Compare August 26, 2026 09:08
Accept copyright notices from any holder instead of requiring SUSE LLC, so external contributors can retain accurate attribution.

Signed-off-by: Akash Kumar <91385321+AkashKumar7902@users.noreply.github.com>
@AkashKumar7902
AkashKumar7902 force-pushed the fix/rubocop-copyright-notice branch from 4fc7cae to 975e443 Compare August 28, 2026 07:48
@cbosdo
cbosdo merged commit 0cd0156 into uyuni-project:master Aug 28, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants