Skip to content

fix(turbopack): isolate runtime public path per bundle #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fireairforce merged 1 commit into from
Sep 24, 2026
Merged

fix(turbopack): isolate runtime public path per bundle #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions turbopack/crates/turbopack-ecmascript-runtime/js/src/shared/runtime/runtime-types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,5 @@ interface TurbopackBaseContext<M> {
z: CommonJsRequire
g: typeof globalThis
p: GetPublicPath
runtimePublicPath: unknown
}
22 changes: 16 additions & 6 deletions turbopack/crates/turbopack-ecmascript-runtime/js/src/shared/runtime/runtime-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,19 @@ contextPrototype.z = requireStub
// Make `globalThis` available to the module in a way that cannot be shadowed by a local variable.
contextPrototype.g = globalThis

// Each runtime keeps its own public path. Other applications on the page may
// change the global path after this runtime has started.
let runtimePublicPath: unknown =
typeof globalThis !== 'undefined'
? (globalThis as any).publicPath
: undefined
Object.defineProperty(contextPrototype, 'runtimePublicPath', {
get: () => runtimePublicPath,
set: (value: unknown) => {
runtimePublicPath = value
},
})

let cachedAutomaticPublicPath: string | undefined

function getAutomaticPublicPath(): string {
Expand Down Expand Up @@ -759,18 +772,15 @@ function getAutomaticPublicPath(): string {

/**
* Gets the public path for runtime assets.
* Checks globalThis.publicPath and falls back to "/".
* Uses this runtime's public path and falls back to "/".
*/
function getPublicPath(mode?: 'auto'): string {
if (mode === 'auto') {
return getAutomaticPublicPath()
}

if (
typeof globalThis !== 'undefined' &&
typeof (globalThis as any).publicPath === 'string'
) {
const publicPath = (globalThis as any).publicPath as string
if (typeof runtimePublicPath === 'string') {
const publicPath = runtimePublicPath
return publicPath.endsWith('/') ? publicPath : `${publicPath}/`
}
return '/'
Expand Down
Loading