Skip to content

fix(turbopack): preserve CSS chunk order in identity - #188

Merged
fireairforce merged 1 commit into
utoofrom
zoomdong/fix-css-chunk-order-ident
Sep 2, 2026
Merged

fireairforce merged 1 commit into
utoofrom
zoomdong/fix-css-chunk-order-ident

Conversation

@fireairforce

Copy link
Copy Markdown
Member

Summary

  • include each multi-item CSS chunk item ordinal in the nested asset key
  • keep single-item CSS chunk identities unchanged
  • distinguish chunks containing the same styles in different cascade orders

Context

Related to utooland/utoo#3332. The Utoo fork makes nested AssetIdent hashing order-independent, while CSS cascade order remains observable. Reusing the same nested key for every CSS item allowed reverse-order chunks to resolve to one output path and trigger conflicting effects during dev writes.

Validation

  • cargo fmt --all
  • cargo clippy --all-targets -- -D warnings --no-deps
  • full pack-tests suite in the linked Utoo follow-up
  • Ant Design issue reproduction: dev HTTP 200 and production build succeeded with the local binding

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-02T07:31:37.857368Z 246eb61 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fireairforce
fireairforce merged commit 346fe8b into utoo Sep 2, 2026
14 of 27 checks passed
fireairforce added a commit that referenced this pull request Sep 14, 2026
Rebased onto vercel/next.js canary 3c9d1ca. Includes the previous
utoo follow-ups:

- feat(turbo-tasks): expose completed task count (#187)
- fix(turbopack): preserve CSS chunk order in identity (#188)
- feat(turbopack): support React 17 compiler target (#189)
- fix(turbopack): honor default chunk content hashing (#190)
- fix(turbopack): fall back after filtering declaration path aliases (#191)
- fix(turbopack): handle undefined defaults in dynamic URLs (#192)

Adaptations for this sync:

- swc v77: build Function.body as FunctionBody in async_module.rs
- turbo-tasks GC roots: extend the wasm in-memory backing storage stub
- lazy dynamic imports: port the follow-reexports evaluation/side-effect
  semantics into module_canonicalization.rs
- strict factory chunks: keep browser_global_ident and compress options
  in the rewritten chunk emitters

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant