feat(turbo-tasks): expose completed task count - #187
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b2dca9f21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.completed_scheduled_tasks | ||
| .fetch_add(1, Ordering::Relaxed); |
There was a problem hiding this comment.
When TurboTasks runs without Utoopack progress reporting—including every caller in this repository—each scheduled task now performs an additional atomic read-modify-write on one shared counter. Task-heavy builds execute these completions concurrently across workers, so this adds hot-path contention and overhead for a metric that is never read; gate the instrumentation behind a consumer-enabled feature/runtime option or use lower-contention aggregation.
AGENTS.md reference: turbopack/AGENTS.md:L1-L3
Useful? React with 👍 / 👎.
Rebased onto vercel/next.js canary 3c9d1ca. Includes the previous utoo follow-ups: - feat(turbo-tasks): expose completed task count (#187) - fix(turbopack): preserve CSS chunk order in identity (#188) - feat(turbopack): support React 17 compiler target (#189) - fix(turbopack): honor default chunk content hashing (#190) - fix(turbopack): fall back after filtering declaration path aliases (#191) - fix(turbopack): handle undefined defaults in dynamic URLs (#192) Adaptations for this sync: - swc v77: build Function.body as FunctionBody in async_module.rs - turbo-tasks GC roots: extend the wasm in-memory backing storage stub - lazy dynamic imports: port the follow-reexports evaluation/side-effect semantics into module_canonicalization.rs - strict factory chunks: keep browser_global_ident and compress options in the rewritten chunk emitters Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2 participants
Summary
Verification