Repository navigation
Conversation
- Pass sectionGroupPresentation: 'tabs', groupPresentation: 'tabs', and sectionComponentPresentation: 'tabs' to renderReport() in RtichokeBrowserReport. - Embed Summary Report density CSS (_summary_report_density_css()) matching R's summary_report_density_css() behavior. - Update unit tests to assert tabs presentation options and density CSS. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
The implementation looks correct and scope-safe. There is one remaining acceptance-test gap before merge. Please extend the existing Summary Report Playwright coverage to exercise at least one component-level tab set introduced by this PR. A minimal sufficient check would be:
and/or equivalently exercise the Discrimination curve tabs ( Keep the existing group-tab Prediction Distribution test. Continue collecting console/page errors and require zero errors. This is a test-only follow-up. Do not change production behavior, ReportSpec content, statistical producers, Also, because the shared wrapper intentionally affects No other changes are requested. |
Extended Playwright acceptance tests in |
- Extend test_browser_summary_report_prediction_distribution_components_render in test_summary_report_browser.py to verify component-level tabs (Calibration Smooth / Discrete and Discrimination curve tabs). - Confirm non-zero chart SVG dimensions and zero console/page errors. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Fixes CI ruff format --check failure in build matrix. Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Aligns Python static browser Summary Report presentation and density CSS with the accepted R browser Summary Report implementation without altering ReportSpec content or producers.
PR created automatically by Jules for task 4093677883993604071 started by @uriahf