Skip to content

Align Python browser Summary Report presentation with R - #422

Merged
uriahf merged 3 commits into
mainfrom
jules/align-browser-summary-report-presentation-4093677883993604071
Sep 17, 2026
Merged

uriahf merged 3 commits into
mainfrom
jules/align-browser-summary-report-presentation-4093677883993604071

Conversation

@uriahf

@uriahf uriahf commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Aligns Python static browser Summary Report presentation and density CSS with the accepted R browser Summary Report implementation without altering ReportSpec content or producers.


PR created automatically by Jules for task 4093677883993604071 started by @uriahf

- Pass sectionGroupPresentation: 'tabs', groupPresentation: 'tabs', and
  sectionComponentPresentation: 'tabs' to renderReport() in
  RtichokeBrowserReport.
- Embed Summary Report density CSS (_summary_report_density_css()) matching R's
  summary_report_density_css() behavior.
- Update unit tests to assert tabs presentation options and density CSS.

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-17 07:35 UTC

@uriahf

uriahf commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

The implementation looks correct and scope-safe. There is one remaining acceptance-test gap before merge.

Please extend the existing Summary Report Playwright coverage to exercise at least one component-level tab set introduced by this PR.

A minimal sufficient check would be:

  • navigate to Calibration;
  • verify the Smooth and Discrete component tabs exist;
  • click each tab and confirm the corresponding component becomes visible;
  • confirm a representative rendered chart/SVG has non-zero dimensions;

and/or equivalently exercise the Discrimination curve tabs (ROC, Lift, Precision-Recall, Gains) inside one operating-point group.

Keep the existing group-tab Prediction Distribution test.

Continue collecting console/page errors and require zero errors.

This is a test-only follow-up. Do not change production behavior, ReportSpec content, statistical producers, rtichoke_viz, or add the cheat sheet.

Also, because the shared wrapper intentionally affects create_summary_report_times(), please confirm in the final report that the existing time-dependent browser tests pass unchanged and that its embedded ReportSpec remains unchanged.

No other changes are requested.

@google-labs-jules

Copy link
Copy Markdown
Contributor

The implementation looks correct and scope-safe. There is one remaining acceptance-test gap before merge.

Please extend the existing Summary Report Playwright coverage to exercise at least one component-level tab set introduced by this PR.

A minimal sufficient check would be:

  • navigate to Calibration;
  • verify the Smooth and Discrete component tabs exist;
  • click each tab and confirm the corresponding component becomes visible;
  • confirm a representative rendered chart/SVG has non-zero dimensions;

and/or equivalently exercise the Discrimination curve tabs (ROC, Lift, Precision-Recall, Gains) inside one operating-point group.

Keep the existing group-tab Prediction Distribution test.

Continue collecting console/page errors and require zero errors.

This is a test-only follow-up. Do not change production behavior, ReportSpec content, statistical producers, rtichoke_viz, or add the cheat sheet.

Also, because the shared wrapper intentionally affects create_summary_report_times(), please confirm in the final report that the existing time-dependent browser tests pass unchanged and that its embedded ReportSpec remains unchanged.

No other changes are requested.

Extended Playwright acceptance tests in test_summary_report_browser.py to cover component-level tab sets (Calibration Smooth and Discrete tabs, as well as Discrimination curve tabs) and verify tab switching, component visibility, non-zero chart SVG dimensions, and zero console/page errors. Also verified that all existing time-dependent browser tests pass unchanged with identical embedded ReportSpec structure.

google-labs-jules Bot and others added 2 commits September 17, 2026 07:28
- Extend test_browser_summary_report_prediction_distribution_components_render
  in test_summary_report_browser.py to verify component-level tabs (Calibration
  Smooth / Discrete and Discrimination curve tabs).
- Confirm non-zero chart SVG dimensions and zero console/page errors.

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Fixes CI ruff format --check failure in build matrix.

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@uriahf
uriahf merged commit 3db8081 into main Sep 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant