Repository navigation
Conversation
- Register prediction_distribution in _V20_SCHEMA_TYPES in _report_spec.py - Embed threshold and PPCR Prediction Distribution components into Discrimination groups in summary_report.py - Extend test suite with structural, identity, grid, schema, and non-regression assertions Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
- Register prediction_distribution in _V20_SCHEMA_TYPES in _report_spec.py - Embed threshold and PPCR Prediction Distribution components into Discrimination groups in summary_report.py - Extend test suite with structural, identity, grid, schema, and non-regression assertions Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
@google-labs-jules This PR is architecturally correct and very close to merge. Please make one final focused browser-acceptance correction. The current browser/Quarto assertions remain generic: rendered.count("<svg") >= 2 These assertions were already satisfied by existing report charts and do not demonstrate that either newly embedded Prediction Distribution component rendered. Please update the existing real-browser Summary Report acceptance test to explicitly verify both new components:
Do not rely only on a page-wide SVG count, because ROC and calibration already satisfy that condition. If the renderer does not expose IDs directly as stable DOM attributes, inspect the actual rendered DOM and use the narrowest stable semantic selectors available. Do not modify "rtichoke_viz" merely to facilitate the test. Also reconsider the unrelated additions of: or "Sensitivity" in tbl_text to the Quarto Performance Table assertions. Remove them unless they are genuinely required by an explained, intended change in Performance Table behavior. Prediction Distribution integration should not weaken unrelated acceptance checks. Keep everything else unchanged:
Run the complete CI suite and report the new head SHA. Do not merge. |
I have addressed all feedback:
|
…ort components - Remove Sensitivity string addition in test_quarto_summary_report_browser.py - Add test_browser_summary_report_prediction_distribution_components_render in test_summary_report_browser.py to explicitly verify SVG rendering and bounding boxes for prediction-distribution and prediction-distribution-2 components across group tabs Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Add Prediction Distribution components to the static browser Summary Report Discrimination section (Probability Threshold and PPCR groups) using existing producers, canonical builders, and ReportSpec v1.1 assembly.
PR created automatically by Jules for task 11575133481170643443 started by @uriahf