Repository navigation
How app deployment works: use dry_run=True, not the deprecated dryrun=True - #1935
Merged
Merged
Conversation
…run=True` Drafted by Docsy for case 3483. Signed-off-by: unionai-docsy-agent[bot] <336110417+unionai-docsy-agent[bot]@users.noreply.github.com>
GHA build & deploy previewBuilt by
Updated automatically on every push. |
unionai-docsy-agent
Bot
requested review from
EngHabu,
cosmicbboy,
kumare3 and
samhita-alla
as code owners
November 9, 2026 13:50
Contributor
Author
|
Docsy actions: what Docsy did on this PR, and at whose direction. Docsy adds a line for each.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the deployment-guide compatibility clarification and numbering fixes.
No open issues 🎉
What changed in this PR
Updates the app deployment guide to recommend dry_run=True while explaining compatibility with older Flyte SDK releases.
Changes:
- Documents the v2.8.0 requirement, deprecated
dryrunalias, and its continued use in the embedded example. - Corrects the best-practices list numbering.
| File | Description |
|---|---|
content/user-guide/apps/serve-and-deploy-apps/how-app-deployment-works.md |
Clarifies dry-run keyword compatibility and fixes list numbering. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed in the product and which signal asked for docs
flyte-sdk renamed
flyte.deploy()'s dry-run keyword fromdryruntodry_runin flyteorg/flyte-sdk#1573 (commit c06a0a72). The change first shipped in v2.8.0. The old name still works, but from v2.8.0 it is a deprecated alias that raises aFutureWarning. Releases before v2.8.0 accept onlydryrun.Signal 3483 is the follow-up work left over when #1884 merged. Most of that work belongs in unionai/unionai-examples, not in this repo:
deploy_examples.py,deployment-planfragment: change the assertion tolen(deployments) == 1andlen(deployments[0].envs) == 2, then restore the embed onhow-app-deployment-works.md.deploy_examples.py,full-deploymentfragment: remove the extraapp.activate()call and changedryrun=Falsetodry_run=False.activation_examples.py: remove or rewrite theactivate-after-deploymentfragment, which no page embeds any more.None of those changes are in this PR. They have to land in unionai-examples first and then be picked up here with a submodule bump. Restoring the
deployment-planembed should wait for fix 1. If it were restored now, the page would show the wronglen(deployments) == 2assertion.Page changed
content/user-guide/apps/serve-and-deploy-apps/how-app-deployment-works.md, under Best practices:dry_run=Trueinstead ofdryrun=True. It also says thatdry_runneedsflytev2.8.0 or later and that earlier versions takedryrun. From v2.8.0,dryrunis a deprecated alias that raises aFutureWarning. The item also notes that the "Example: Full deployment configuration" embed above it still usesdryrun, so readers aren't left with two keyword names on one page and no explanation.Evidence
git tag --contains c06a0a72listsv2.8.0as the earliest tag.v2.7.2,src/flyte/_deploy.pydeclares onlydryrun: bool = Falseondeploy().v2.8.0, the same file declaresdry_run: bool = Falseanddryrun: bool | None = None. The docstring callsdryruna "Deprecated alias fordry_run, kept for backwards compatibility". Later tags have the same signature, includingv2.12.4,v2.12.5andv2.13.0.flyte==2.13.0, the latest release,inspect.signature(flyte.deploy)lists both parameters. Callingflyte.deploy(env, dryrun=True)raisedFutureWarning: flyte.deploy(dryrun=...) is deprecated, use flyte.deploy(dry_run=...) instead.content/release-notes/2026-09.md) also record the deprecation.full-deploymentfragment in unionai-examples at the pinned submodule commit (fdf2e261) callsflyte.deploy(..., dryrun=False, ...).Open questions / known gaps
dryrun=Falseand an unneededapp.activate(). The best-practices item points out thedryrunmismatch. Once fix 2 lands and the submodule is bumped, that sentence should be removed.deployment-planfragment, corrected as in item 1 above, before its embed goes back into the "Deployment plan" section.flyteSDK version for the 2.x guide as a whole. Becausedry_run=raises aTypeErrorbefore v2.8.0, the item states the version condition directly. If the docs adopt a site-wide minimum of v2.8.0 or later, the version note can go.Pre-flight review
Docsy's reviewer read this draft before it was opened and found 4 problems to fix. The draft was amended for them, and a check of the amendment found nothing left to fix.
Its optional suggestions, which the page doesn't need to be right; take them or not:
content/user-guide/apps/serve-and-deploy-apps/how-app-deployment-works.mdline 86:content/user-guide/tasks/task-deployment/deploy-command-options.md(around line 315) has a hand-written Python block in this repo, not an embed, that passesdryrun=False # Set to True for dry runtoflyte.deploy(). Unlike the embedded example on this page, that block can be fixed in this PR with no unionai-examples change. A note: theanalytics.deploy(dryrun=True)mention infactories/materialize.mdis a different API, and this review didn't check it.Docsy case 3483: https://docsy.apps.demo.hosted.unionai.cloud/cases/3483
Drafted by Docsy, Union.ai's documentation agent, from the product changes and requests in this case. Review it like any PR; close it if it's not wanted.