feat: bound pipeline work items with a per-item timeout - #60
Merged
Conversation
lollllcat
force-pushed
the
pipeline-timeout
branch
from
July 27, 2026 21:15
42f1bc8 to
6ce3044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKITEM_TIMEOUT_SEC(default 120min, override viaCRISP_WORKITEM_TIMEOUT_SEC) tocrisp/pipeline.py: a work item running longer than this gets its worker process force-killed (terminate(), escalating tokill()if needed) and itsConfigmarkedfailed, instead of blocking the pipeline stage forever.pipelineWorkerReal's wait loop now boundsmp.connection.wait(...)by the soonest deadline and reaps expired workers each time it times out. Only applies to non-serialize (multiprocess) phases._flushReadyItems()helper.Test plan
pytestfull suite passes (647 passed)bazel test //...passes (33/33 targets)