Repository navigation
Update toml-tidy to 0.7.0 - #1190
Open
AndrewDongminYoo wants to merge 1 commit into
Open
AndrewDongminYoo wants to merge 1 commit into
AndrewDongminYoo wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
known_good_versionfortoml-tidyfrom 0.3.1 to 0.7.0, renames the fmt snapshot accordingly, and declares the standalone configuration files that 0.7.0 reads.What is new upstream
.toml-tidy.tomlandtoml-tidy.tomlas well as[tool.toml-tidy]inpyproject.toml, with Ruff-style discovery (the closest file above each target applies). Repositories without apyproject.tomlcan now configure it under Trunk. The definition lists both files indirect_configs, the same shape asruff'sdirect_configs: [ruff.toml], and keepspyproject.tomlinaffects_cache.--order versionand--diff, and its own pre-commit hook no longer touches lockfiles.--in-placewrites atomic; 0.5.0 and 0.6.0 normalize the spacing of single-line arrays by default and add an opt-in--line-width.The command this plugin runs (
toml-tidy --in-place ${target}) is unchanged.The fixture has no arrays, so the snapshot content is byte-identical to the 0.3.1 one and only the version in its filename changed (
git diff -Mreports the rename as 100% similarity).The README now names 0.7.0 and the new configuration files.
Verification
PLUGINS_TEST_LINTER_VERSION=KnownGoodVersion npx jest linters/toml-tidy --ci→ 1 test passed, 1 snapshot passed against the renamedtoml_tidy_v0.7.0_basic.fmt.shot.As a hermeticity check,
PLUGINS_TEST_LINTER_VERSION=0.99.0fails with a task failure, so the test installs the pinned version rather than atoml-tidyalready onPATH.