Skip to content

update hadolint download urls for >=2.13.1 - #1085

Merged
EliSchleifer merged 1 commit into
trunk-io:mainfrom
gejustin:gjustin/hadolint-download-urls
Sep 18, 2025
Merged

update hadolint download urls for >=2.13.1#1085
EliSchleifer merged 1 commit into
trunk-io:mainfrom
gejustin:gjustin/hadolint-download-urls

Conversation

@gejustin

@gejustin gejustin commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

Hadolint 2.13.1 is currently failing to install on arm64 Mac (likely others). It appears as though the naming conventions of the downloadable assets were changed in 2.13.1 - https://github.com/hadolint/hadolint/releases. There also appears to be no 2.13.0 tag 🤷

trunk_cli_version: 1.25.0
title: "Error while executing: Installing hermetic tool hadolint v2.13.1"
report:
  - HTTP 404 'https://github.com/hadolint/hadolint/releases/download/v2.13.1/hadolint-Darwin-x86_64'

Solution

I've added support for versions >= 2.13.1 using the new paths.

@EliSchleifer
EliSchleifer self-requested a review September 18, 2025 17:41
EliSchleifer
EliSchleifer approved these changes Sep 18, 2025
View reviewed changes

@EliSchleifer EliSchleifer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EliSchleifer
EliSchleifer merged commit a2149c5 into trunk-io:main Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EliSchleifer EliSchleifer EliSchleifer approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gejustin @EliSchleifer