Add Requires header fields and fix implicit-nullable deprecations - #7
Merged
Merged
Conversation
…tions Add "Requires at least" / "Requires PHP" to the plugin header to match the versions already documented in README.md. Also explicitly mark Term_Manager::__construct()'s $time and Term\UI::add_column_value()'s $column_value / $custom_column parameters as nullable, since PHP 8.4+ deprecates relying on a "= null" default to imply a nullable type.
Closed
There was a problem hiding this comment.
Pull request overview
Adds WordPress/PHP compatibility metadata to the plugin header and resolves PHP 8.4+ “implicit nullable” deprecation warnings by making affected parameters explicitly nullable.
Changes:
- Add
Requires at least: 6.7andRequires PHP: 8.2to the plugin header inschedule-terms.php. - Update
Term_Manager::__construct()to use?int $time = null. - Update
Term\UI::add_column_value()to use?stringparameters and adjust related docblocks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schedule-terms.php | Adds WordPress/PHP minimum version requirements to the plugin header. |
| includes/Term/UI.php | Makes custom column callback parameters explicitly nullable to avoid implicit-nullable deprecations. |
| includes/Term_Manager.php | Makes $time explicitly nullable (?int) to avoid implicit-nullable deprecations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
232
to
+234
| * @return string|void | ||
| */ | ||
| public function add_column_value( string $column_value = null, string $custom_column = null, int $term_id = 0 ) { | ||
| public function add_column_value( ?string $column_value = null, ?string $custom_column = null, int $term_id = 0 ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires at least: 6.7/Requires PHP: 8.2to the plugin header inschedule-terms.php, matching what's already documented in README.md.Term_Manager::__construct()'s$timeparameter andTerm\UI::add_column_value()'s$column_value/$custom_columnparameters as nullable (?int/?string), resolving the PHP 8.4+ "implicitly marking parameter as nullable is deprecated" warnings surfaced bycomposer lint.Test plan
composer lintno longer prints anyDeprecated:outputnpm run test:php(PHPUnit via wp-env) passes