fix: accept image drops on the empty state, not only a loaded canvas - #49
Merged
Merged
Conversation
) The drop handler lived on CanvasNSView, which is only created once a document exists. The empty state that says "drop an image" therefore had no drop registration and Finder drops did nothing. Move drop handling to the SwiftUI canvas pane via dropDestination(for:) with a DroppedImage Transferable that accepts either a file URL (Finder) or image bytes (browser/app drags), so both states share one path. The AppKit performDragOperation is removed rather than duplicated. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
tk3fftk
marked this pull request as ready for review
September 6, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drop handler lived on CanvasNSView, which is only created once a document exists. The empty state that says "drop an image" therefore had no drop registration and Finder drops did nothing.
Move drop handling to the SwiftUI canvas pane via dropDestination(for:) with a DroppedImage Transferable that accepts either a file URL (Finder) or image bytes (browser/app drags), so both states share one path. The AppKit performDragOperation is removed rather than duplicated.