ci: green type check on a fresh checkout, and a working pip cache path - #162
Closed
titanwings wants to merge 1 commit into
Closed
titanwings wants to merge 1 commit into
titanwings wants to merge 1 commit into
Conversation
…cache path The TypeScript job has been red on this branch since before this work: the type-check step runs before any build, so every project reference fails with TS6305 on a fresh checkout, and the Ruff job failed inside setup-python because the pip cache asked for a requirements.txt the repository does not have. typecheck now builds the referenced projects first, which also makes the gate usable locally on a clean clone, and the Ruff job points its cache at requirements-dev.txt. Verified by moving every package's built output aside and running the gate: it passes from that state.
Owner
Author
|
Superseded: this stacked series is consolidated into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the repository CI usable again:
pnpm run typechecknow builds the referenced projects first, so it works on a fresh checkout instead of failing every project reference withTS6305.requirements-dev.txt;actions/setup-pythonwas failing before Ruff ran at all, because the repository has norequirements.txt.Both failures pre-date this branch: every recent CI run on
distilly-pluginis red for the same reasons.Verification
Moved every package's built output aside to simulate a fresh checkout, then ran
pnpm run typecheck: exit 0, zero errors. Format and lint gates pass.Stack
Stacked on
pr/12-audit-fixes-and-repair; the series ends atdistilly-work(9ab229e).