Add pre-push checklist to CLAUDE.md#5083
Closed
vara2504 wants to merge 3 commits into
Closed
Conversation
vara2504
force-pushed
the
vara-claude-md-pre-push-checklist
branch
from
July 21, 2026 23:42
71b979f to
dbeb5d0
Compare
| ``` | ||
|
|
||
| ### Pre-push Checklist | ||
| After making changes, run these before pushing to avoid CI failures: |
Member
There was a problem hiding this comment.
I don't think we should be having Claude run these command unconditionally - many changes don't need these, and it's going to add extra time to each push.
At a minimum we should be a bit smarter about explaining what sort of changes should trigger running which commands.
Contributor
Author
There was a problem hiding this comment.
@caseydavenport updated so each command is gated by change type rather than run unconditionally:
- static-checks (the slow golangci-lint container pass) now only runs after Go code changes, not on every push.
- dirty-check moved next to gen-files, where it just confirms regenerated files are committed.
- gen-files stays scoped to API/CRD/config changes.
vara2504
force-pushed
the
vara-claude-md-pre-push-checklist
branch
2 times, most recently
from
July 21, 2026 23:58
37143db to
7e9fcd6
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vara2504
force-pushed
the
vara-claude-md-pre-push-checklist
branch
from
July 22, 2026 00:04
7e9fcd6 to
305cf6b
Compare
Address review feedback: each pre-push command now runs only for the change type that needs it, so a docs/YAML/comment-only push runs none. static-checks (golangci-lint) and dirty-check no longer run unconditionally on every push. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
None
🤖 Generated with Claude Code