Repository navigation
Keep tracing other processes when a child is killed by a signal - #6
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
The Signaled arm always broke out of the trace loop, so with -f the first traced child to die from a signal ended the whole trace and left the remaining tracees behind. Only stop once no traced PIDs are left, as the Exited arm already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-f, theWaitStatus::Signaledarm always broke out of the trace loop, so the first traced child killed by a signal ended the trace and the parent's later syscalls were never shown. It now stops only once no traced PIDs remain, like theExitedarm. Addedtest_follow_forks_continues_after_child_killed_by_signal;cargo test -- --test-threads=1passes on Linux.