Rename module path zos4 -> zos_v4 (match repo, off redirect) - #34
Merged
Conversation
The repo was renamed zos4 -> zos_v4, but the module still declared github.com/threefoldtech/zos4, which relies on the (non-permanent) rename redirect and collides with zoslight/zos_light. Rename the main + nested (tools/zos-update-version) module directives, internal imports, and Makefile ldflags to github.com/threefoldtech/zos_v4. Both modules build. The zosbase dependency is left at v1.0.3 (separate, deferred migration). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ashraffouda
requested review from
Eslam-Nawara,
Omarabdul3ziz,
rawdaGastan and
xmonader
as code owners
July 14, 2026 11:49
The Set up Go step (setup-go@v1) fails on the current GitHub host runner, blocking Build and upload / Running Daemon Tests before the module-rename build runs. Bump to v5. Container builders untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the Go module path github.com/threefoldtech/zos4 -> github.com/threefoldtech/zos_v4 to match the renamed repo, off the zos4->zos_v4 rename redirect and out of the module-path collision with zos_light (which also wrongly declared .../zos4). Covers the main module + the nested tools/zos-update-version module directives, internal imports (gofmt'd), and Makefile ldflags. Both modules build. The zosbase dependency is left at v1.0.3 (the zos_base@v1.1.0 migration is deferred separately due to Provision.ListTwins API drift). Part of #2693.