[Automated] Update flux CLI Options - #3909
Conversation
thomhurst
added
automated
dependencies
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (45)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7a1ee999f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [CliArgument(0, Phase = CommandLinePhase.EarlyOperand)] | ||
| public string? Command { get; set; } | ||
|
|
||
| } |
There was a problem hiding this comment.
When consumers use the previously public Command property to dispatch a subgroup (for example, new FluxBuildOptions { Command = "artifact" }), removing it from these 36 option records causes source compilation failures and MissingMethodException for already-compiled callers invoking its accessor. Preserve it as an obsolete positional alias until a major release, implementing the compatibility behavior in the generator or a manual extension rather than editing generated output directly.
AGENTS.md reference: AGENTS.md:L164-L169
Useful? React with 👍 / 👎.
| [CliSubCommand("plugin", "install")] | ||
| public record FluxPluginInstallOptions( | ||
| [property: CliArgument(0, Phase = CommandLinePhase.EarlyOperand, Required = true)] string NameVersion | ||
| [property: CliArgument(0, Phase = CommandLinePhase.EarlyOperand, Required = true)] string Name |
There was a problem hiding this comment.
When existing callers use the public positional-record property or named argument NameVersion, renaming it to Name breaks source compatibility, and already-compiled code that reads get_NameVersion() fails at runtime. The CLI operand is still represented by the same string constructor value, so retain an obsolete forwarding NameVersion property (or defer the rename to a major release) through the generator's compatibility mechanism.
AGENTS.md reference: AGENTS.md:L164-L169
Useful? React with 👍 / 👎.
Code ReviewThis PR is a fully mechanical, generator-produced update: it bumps the Flux CLI wrapper from I checked each notable diff for correctness/regression risk:
No other correctness, design, or maintainability issues found. Since this is 100% generated output with no manual edits, there isn't a design-pattern or architectural angle to critique here — the generator's existing conventions are being followed faithfully. 🤖 Generated with automated code review |
1 participant
Summary
This PR contains automatically generated updates to flux CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator