Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the script
scripts/findRelatedCards.tsto generate likelyrelated(translation) candidates. This script generates a hash from card metadata to cluster likely related cards (primarily using the card's illustrator combined with card type and additional fields). It allows to output JSON or default console logging.Example execution:
Example output:
{ "5ban Graphics:Pokemon:Double rare:Stage1:340:Fighting:-:-:Fighting130,Fighting+Fighting270:2": [ { "path": "data/Mega Evolution/Ascended Heroes/113.ts", "url": "https://assets.tcgdex.net/en/me/me02.5/113/high.png", "cardId": "113", "setId": "me02.5", "serieId": "me", "lang": "en" }, { "path": "data/Mega Evolution/Mega Evolution/077.ts", "url": "https://assets.tcgdex.net/en/me/me01/077/high.png", "cardId": "077", "setId": "me01", "serieId": "me", "lang": "en" } ] }Caveats
illustratorfield to be set, which is not everywhere (either missing or not on Energy cards); but other hashes might make sense, too (dexIdfield is also not everywhere, so unreliable)relatedto include more than "translations"?/en/bw/bw4/50/,/en/bw/bwp/BW24/,/en/bw/bw1/47/have different art (same illustrator) but are otherwise identical...Ideas
sets(seriesshould probably be done manually) based on common card mappings?