Skip to content

west.yml: update zephyr (Aug 28th) - #11098

Open
kv2019i wants to merge 2 commits into
thesofproject:mainfrom
kv2019i:202608-zephyr-aug14
Open

west.yml: update zephyr (Aug 28th)#11098
kv2019i wants to merge 2 commits into
thesofproject:mainfrom
kv2019i:202608-zephyr-aug14

Conversation

@kv2019i

@kv2019i kv2019i commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings August 14, 2026 08:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Zephyr dependency revision and adapts Intel ADSP SMP bring-up behavior by removing an app-level Kconfig default and replacing it with board-specific devicetree overlays that defer secondary CPU start.

Changes:

  • Bump west.yml Zephyr revision to bfa1218a9e63a9621316178ca2c3125d16844a96.
  • Remove the SMP_BOOT_DELAY Kconfig symbol default from app/Kconfig.
  • Add per-board .overlay files to apply zephyr,deferred-start to secondary CPU nodes on affected Intel ADSP boards.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
west.yml Updates the pinned Zephyr revision in the west manifest.
app/Kconfig Drops the former SMP boot-delay default Kconfig symbol.
app/boards/intel_adsp_cavs25.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_cavs25_tgph.overlay Defers start of secondary CPU via zephyr,deferred-start.
app/boards/intel_adsp_ace40_nvls.overlay Defers start of secondary CPU via zephyr,deferred-start.
app/boards/intel_adsp_ace40_nvl.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace30_wcl.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace30_wcl_sim.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace30_ptl.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace30_ptl_sim.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace20_lnl.overlay Defers start of secondary CPUs via zephyr,deferred-start.
app/boards/intel_adsp_ace15_mtpm.overlay Defers start of secondary CPUs via zephyr,deferred-start.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kv2019i
kv2019i requested review from jsarha and lyakh August 14, 2026 08:51
@kv2019i kv2019i changed the title west.yml: update zephyr to bfa1218a9e63 west.yml: update zephyr to bfa1218a9e63 (Aug 14th) Aug 14, 2026
@kv2019i

kv2019i commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

We are having some CI fails due to cmake minimum-req bump in Zephyr commit:

commit a45dd41d34be1dec1cc0da8897cc15ae82af82e2
Author: Benjamin Cabé <benjamin@zephyrproject.org>
Date:   Mon Aug 3 19:45:35 2026 +0000

    build: bump minimum CMake version to 3.28.0 in new CMakeLists files

@lrudyX

lrudyX commented Aug 18, 2026

Copy link
Copy Markdown

We are having some CI fails due to cmake minimum-req bump in Zephyr commit:

commit a45dd41d34be1dec1cc0da8897cc15ae82af82e2
Author: Benjamin Cabé <benjamin@zephyrproject.org>
Date:   Mon Aug 3 19:45:35 2026 +0000

    build: bump minimum CMake version to 3.28.0 in new CMakeLists files

@kv2019i Yes, bumping newer cmake in a pipeline failed at first try, I will let you know, when the pipeline is ready.

@wjablon1

wjablon1 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

I solved this directly in DTS: zephyrproject-rtos/zephyr#116943 without creating additional files. IMO those overlays would come in handy if we had plans for changing this behavior (starting FW with primary core only) in the future. So please decide.

@kv2019i

kv2019i commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator Author

@wjablon1 wrote:

I solved this directly in DTS: zephyrproject-rtos/zephyr#116943 without creating additional files. IMO those overlays would come in handy if we had plans for changing this behavior (starting FW with primary core only) in the future. So please decide.

This is a bit tricky. We have two complicating factors:

  • This is not really a property of the hardware. It's just that SOF the application wants to control core power up/down directly (as we have IPCs that host sends to power-up/down cores). In this sense, the old CONFIG_SMP_BOOT_DELAY served us better (as we could set this in SOF for all targets, not just Intel hardware).
  • Only multicore (CONFIG_SMP) targets we have in SOF are Intel DSPs. So in practise your Zephyr PR116943 will just work.

Unless anyone objects (probably would be someone outside Intel), I think we can proceed with your Zephyr PR. This PR is anyways stuck due to cmake dependencies. I'll keep this open until your PR is merged (the overlays I add here won't cause problem, they will just become unnecessary).

If in the future, somebody wants to support CONFIG_SMP with a new target in SOF, either one needs to add deferred attribute on Zephyr side, add an overlay like here (= allows to use traditional Zephyr SMP, maybe for some other app than SOF), or implement new code in SOF.

@abonislawski

abonislawski commented Aug 21, 2026

Copy link
Copy Markdown
Member

I agree with @kv2019i. At first glance, it looks overcomplicated, but these are indeed application settings, and this is the proper way to pass them.

For simplicity, I think we can use the setting directly in Zephyr in our case. However, if more such settings are introduced, we should create our own overlays like in this PR.

@wjablon1

wjablon1 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

It's not like we have two equivalent methods of achieving the same goal because even in @kv2019i approach it's still done through the DTS property. @kv2019i just split DTS by creating those overlays... I also considered this, but my concern was that those overlays could be abused in the future (e.g. by choosing a quick fix instead of going through full zephyr integration path), so IMO we must have a good reason to do so. But I also understand your perspective, so I don't mind canceling my Zephyr PR.

@kv2019i

kv2019i commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@wjablon1 Let's proceed with your Zephyr PR. I think @abonislawski is for this as well (he approved the Zephyr PR :) )

@abonislawski

Copy link
Copy Markdown
Member

Yes, sorry if that wasn’t clear. We’ll revisit overlays when there are more reasons to use them :)

@lgirdwood

Copy link
Copy Markdown
Member

@wjablon1 Let's proceed with your Zephyr PR. I think @abonislawski is for this as well (he approved the Zephyr PR :) )

@kv2019i the Zepphyr PR from @wjablon1 is now merged, do we need to update this now ?

@kv2019i

kv2019i commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Ack @lgirdwood , will update. Not sure if the cmake upgrade has been done, so the PR might still fail (until cmake is upgraded succesfully in all CI nodes). @lrudyX any updates with cmake ?

@kv2019i
kv2019i force-pushed the 202608-zephyr-aug14 branch from fbe82ad to 1f37c26 Compare August 25, 2026 13:28
@kv2019i kv2019i changed the title west.yml: update zephyr to bfa1218a9e63 (Aug 14th) west.yml: update zephyr to bfa1218a9e63 (Aug 25th) Aug 25, 2026
@kv2019i

kv2019i commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

V2:

@lrudyX

lrudyX commented Aug 25, 2026

Copy link
Copy Markdown

Ack @lgirdwood , will update. Not sure if the cmake upgrade has been done, so the PR might still fail (until cmake is upgraded succesfully in all CI nodes). @lrudyX any updates with cmake ?

No change

@lgirdwood

Copy link
Copy Markdown
Member

Ack @lgirdwood , will update. Not sure if the cmake upgrade has been done, so the PR might still fail (until cmake is upgraded succesfully in all CI nodes). @lrudyX any updates with cmake ?

No change

@lrudyX is there an ETA for this ?

@kv2019i

kv2019i commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

V2:

  • add a second commit to disbale the build warnings due to deprecated zephyr/sys_clock.h . I left this as separate commit as bisect is not broken (a build warning)

@intel-sofci

Copy link
Copy Markdown

PR 11098: test results

Run date: 2026-08-26 14:15 UTC

Tested commit: 00544ffc07574cf477078d1daa197720435926c0

mtl pass rate lnl pass rate ptl pass rate wcl pass rate nvl pass rate

@kv2019i
kv2019i force-pushed the 202608-zephyr-aug14 branch from 00544ff to c805ab7 Compare August 26, 2026 16:22
@kv2019i

kv2019i commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

V3:

  • on additional compiler warning fixed related to sys_clock.h deprecation in Zephyr

@kv2019i
kv2019i force-pushed the 202608-zephyr-aug14 branch from c805ab7 to 37cd811 Compare August 26, 2026 16:54
@kv2019i

kv2019i commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

V4:

  • include the actual fix

@serhiy-katsyuba-intel

Copy link
Copy Markdown
Contributor

Just in case of a next update here it would be nice to include this fix: zephyrproject-rtos/zephyr#116159

@abonislawski

Copy link
Copy Markdown
Member

@kv2019i looks like we need to use overlay approach:
zephyrproject-rtos/zephyr#117664

Total of 3177 commits.

Changes include:

ddea58c9940f coredump: intel_adsp_mem_window: reuse the telemetry slot
	     if one exists
a270495489e9 coredump: intel_adsp_mem_window: clamp writes to the debug
	     slot size
ef1bbd2fd1f5 drivers: uaol: log the link and stream configuration
d943840e1b66 drivers: uaol: re-initialize the link after a power cycle
3ae0c77dd749 drivers: dai: allow bespoke config blobs larger than the
             stack buffer
c0926335d490 dts: intel_adsp: align boards to new CPU deferral config
7a72151634e8 kernel: smp: replace SMP_BOOT_DELAY with per-CPU
             devicetree deferral
8ab6cd9190ad arch: xtensa: mmu: defer TLB flush on ASID free using
             dirty bitmap
3590f4b45b6a arch: xtensa: mmu: add PTEVADDR 0x60000000 option, cap
             ASID range
cf244b983d8a arch: xtensa: mmu: add ASID recycling for memory domains
78ca43befcd4 xtensa: skip mmu/mpu swapping if same memory domain
54a45000c0d0 xtensa: move CONFIG_ARCH_HAS_DIRECTED_IPIS to SoC
d9db3de0d46b arch: xtensa: fix arch_user_string_nlen() reading past
             maxsize
d73ef2de7b83 drivers: dai: intel: ssp: Fix aux data size check for DMA
             transmission
48fb236912d9 counter: ace_v1x: fix header include issue
85c1c4c21945 kernel: userspace: reject size overflow in dynamic object
             allocation
2cb53feca11e llext-edk: Properly get topdir when --sysbuild is used
d46238fd276a logging: do not pass an uninitialized spinlock key
da95dbff265e logging: log_mgmt: Add missing cache releasing

Additional changes:
- app/Kconfig: drop the SMP_BOOT_DELAY default, because Zephyr commit
  7a72151634e8 replaced CONFIG_SMP_BOOT_DELAY with per-CPU devicetree
  deferral and the symbol no longer exists.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Using zephyr/sys_clock.h is deprecated in upstream Zephyr and has
emitted a build warning since Zephyr commit 5b2fd0761d88 ("include:
zephyr: Warn when deprecated include/zephyr/sys_clock.h is used"). Fix
the warnings and include zephyr/sys/clock.h instead.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
kv2019i force-pushed the 202608-zephyr-aug14 branch from 37cd811 to b476c3c Compare August 28, 2026 12:12
@kv2019i kv2019i changed the title west.yml: update zephyr to bfa1218a9e63 (Aug 25th) west.yml: update zephyr (Aug 28th) Aug 28, 2026
@kv2019i

kv2019i commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

V5:

  • bumped Zephyr to newer
  • this version doesn't have the DTS overlays yet, I'll add it to the next version (this PR or separate, depending on whether we can merge this or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants