TAC5572, TAC5682 Support on Intel - #5883
Open
niranjanhyti wants to merge 2 commits into
Open
Conversation
niranjanhyti
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063,
shumingfan and
ujfalusi
as code owners
August 19, 2026 06:37
Collaborator
|
Can one of the admins verify this patch?
|
Add tac5572, tac5682 to the wake_capable_list as it can generate jack events whilst the bus is stopped. Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
Add Texas Instrument's tac5xx2-sdw family to include support for soundwire codecs tac5572, tac5682 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
Collaborator
|
test this please |
bardliao
approved these changes
Aug 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds support for TI TAC5572/TAC5682 SoundWire smart amplifiers on Intel platforms by enabling the TAC5XX2 SoundWire codec driver in the Intel SoundWire SOF generic machine configuration and by marking these parts as wake-capable in the Intel SoundWire manager.
Changes:
- Select
SND_SOC_TAC5XX2_SDWforSND_SOC_INTEL_SOUNDWIRE_SOF_MACHto ensure TAC5XX2 SDW codec support is built for Intel SoundWire SOF machines. - Add TAC5572/TAC5682 (mfg
0x0102) to the Intel SoundWire wake-capable part list so they can be placed in the wake-capable device-number range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sound/soc/intel/boards/Kconfig | Enables TAC5XX2 SoundWire codec support for the Intel SoundWire SOF generic machine driver. |
| drivers/soundwire/intel_auxdevice.c | Marks TAC5572/TAC5682 as wake-capable parts for Intel SoundWire manager handling. |
Suppressed comments (1)
sound/soc/intel/boards/Kconfig:540
- The help text for this machine driver lists supported codecs/amplifiers but does not mention the newly selected TAC5XX2 family, which can mislead users about what enabling this option provides.
select SND_SOC_TAC5XX2_SDW
select SND_SOC_DMIC
select SND_SOC_INTEL_HDA_DSP_COMMON
imply SND_SOC_SDW_MOCKUP
help
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
535
to
537
| select SND_SOC_ES9356 | ||
| select SND_SOC_TAC5XX2_SDW | ||
| select SND_SOC_DMIC |
Collaborator
There was a problem hiding this comment.
@niranjanhyti Please check the Copilot comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TI's TAC5572, TAC5682 Support on Intel.