Add a Marketplace icon - #28
Open
Chirag6722 wants to merge 1 commit into
Open
Conversation
Fixes thegoodengineer#4 package.json had no top-level icon, so the Extensions view, the VSIX install listing and the Marketplace page all fell back to the default grey placeholder. media/icon.svg was wired only to the viewsContainers contribution, which is the Activity Bar glyph and nothing else, and the Marketplace does not accept SVG for this field. media/icon.png is the same glyph at 128x128: the disc from icon.svg with the checkmark knocked out of it, in the green the sidebar already uses for a command that exited 0. The check is knocked out rather than painted on, exactly as the SVG's fill-rule="evenodd" does it, so it reads on a light or a dark Marketplace theme. media/** is deliberately absent from .vscodeignore so the file ships. Confirmed with vsce ls, which lists media/icon.png in the package and validates the icon field on the way past (it rejects SVG there, so a clean run is a real check, not just a listing). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4, per your direction: the existing glyph at 128x128 PNG, wired to the top-level
iconfield, withmedia/**kept out of.vscodeignoreso it ships.package.jsonhad no top-levelicon, so the Extensions view, the VSIX install listing and the Marketplace page all fell back to the grey placeholder.media/icon.svgwas wired only toviewsContainers, which is the Activity Bar glyph and nothing else, and the Marketplace does not accept SVG for this field.media/icon.pngis the same shape asicon.svg: the disc, with the checkmark knocked out of it rather than painted on, which is what that path'sfill-rule="evenodd"does. Knocking it out means the check picks up whatever is behind it, so it stays legible on a light or a dark Marketplace theme instead of being tuned for one. The green is the one the sidebar already uses for a command that exited 0, so the icon says the same thing the UI does.How it was made, since this matters if you ever edit the SVG. There is no SVG rasteriser available on this machine, so rather than eyeball a redraw I took the path data straight out of
icon.svgand replayed it: disc atcx=12, cy=12, r=10, then the checkmark polygon(10.8,16.4) (6,11.6) (7.44,10.16) (10.8,13.52) (17.76,6.56) (19.2,8), which is that path'sm/lcommands resolved to absolute coordinates in the 24-unit viewBox. Rendered 8x and downsampled with LANCZOS for clean edges. So it is the same geometry, not an approximation of it. I did not commit the generator, since a Python/Pillow script sits oddly in a TypeScript repo, but the recipe is here in the history if you need to regenerate it.Verified with
vsce ls, which listsmedia/icon.pngin the package and validates theiconfield as it goes (it refuses an SVG there, so a clean run is an actual check):If the colour or the crop is not what you want, that is a two-minute change and I would rather you have the icon you want than the one I picked.