fix(github): bind /builder to the plan the approver selected - #259
Open
islahuddinn wants to merge 1 commit into
Open
fix(github): bind /builder to the plan the approver selected#259islahuddinn wants to merge 1 commit into
islahuddinn wants to merge 1 commit into
Conversation
Supersede older open plan_acceptance proposals when a newer Architect run opens on the same issue, refuse bare /builder when multiple live plans exist, and accept `/builder <proposal-id>` for explicit Gate 1 binding. Fixes theam#233 Co-authored-by: Cursor <cursoragent@cursor.com>
islahuddinn
force-pushed
the
fix/github-builder-plan-binding-233
branch
from
September 2, 2026 07:13
7717db4 to
3dac681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_acceptanceproposals when a newer Architect run opens on the same issue, so only one live plan remains in the common case./builderwhen multiple live plans exist on an issue (builder_plan_ambiguous)./builder <proposal-id>(and/codex-builder <proposal-id>) to bind Gate 1 approval to the plan the human actually reviewed.Fixes #233
Test plan
vitest run test/plan-acceptance.test.ts test/builder-plan-policy.test.ts test/github.test.ts test/github-run-progress.test.tsvitest run test/builder-plan-policy.integration.test.ts(requires Postgres atDATABASE_URL)/architecttwice on one issue, verify bare/builderis blocked and/builder prop_…approves the intended planMade with Cursor