Skip to content

fix(cli): improve cross-platform dev experience and onboarding - #257

Open
islahuddinn wants to merge 1 commit into
theam:mainfrom
islahuddinn:fix/cli-dev-experience-241-240-229
Open

fix(cli): improve cross-platform dev experience and onboarding#257
islahuddinn wants to merge 1 commit into
theam:mainfrom
islahuddinn:fix/cli-dev-experience-241-240-229

Conversation

@islahuddinn

Copy link
Copy Markdown

Summary

Three small, related contributor-facing fixes:

#241 — Windows-safe CLI test gh stubs

  • Adds shared packages/cli/test/gh-stub.mjs
  • Installs cross-platform gh shims (gh.cmd on Windows, executable wrapper elsewhere)
  • Joins PATH with path.delimiter instead of hard-coded :
  • Sets invalid GH_HOST / GH_TOKEN so tests fail closed if the stub does not engage
  • Skips POSIX 0600 mode assertions on Windows (NTFS has no meaningful Unix modes)

#240 — Node engine floor for pnpm 11

  • Raises root engines.node to >=22.13.0
  • Adds preinstall probe that requires the node:sqlite builtin pnpm 11 depends on
  • Documents the requirement in CONTRIBUTING.md

#229 — unreachable --canary-bot init flag

  • Allowlists --canary-bot in the init CLI validator and help text
  • Adds an init test asserting the custom canary bot login renders into the crew workflow

Fixes #241
Fixes #240
Fixes #229

Test plan

  • pnpm --filter @theagilemonkeys/facility test (102 passed, 1 skipped)
  • Delivery and doctor resolver tests still use deterministic gh fixtures
  • Init test covers --canary-bot=acme-canary[bot]

Made with Cursor

@islahuddinn
islahuddinn force-pushed the fix/cli-dev-experience-241-240-229 branch 2 times, most recently from e971de1 to f90f7ac Compare September 2, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment