Polarization Matching for the Expansion of Planewaves in Planewavebasis#17
Open
elias-w-k-herzog wants to merge 3 commits into
Open
Polarization Matching for the Expansion of Planewaves in Planewavebasis#17elias-w-k-herzog wants to merge 3 commits into
elias-w-k-herzog wants to merge 3 commits into
Conversation
Collaborator
|
The example of a plane wave expanded into a basis of plane waves in the docs had the wrong amplitudes due to the missing polarization matching, making the doctests fail. This is fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issues coming up by expanding a plane wave into a plane wave basis, the matching of the polarizations has been added. Additionally the override of the array function has been modified according to the migration guide of numpy.