d2svg: respect reduced motion for animated connections#2778
Draft
coyaSONG wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-reduced-motion: reduceoverride for animated SVG connectionsWhy
Animated connection paths receive their animation through an inline style. The reduced-motion rule therefore uses
animation: none !importanton.animated-connectionso the operating-system accessibility preference reliably wins without changing the normal rendered output.Validation
./make.sh lintwith the repository-pinned Go 1.25.0 toolchain./make.sh buildwith the repository-pinned Go 1.25.0 toolchain./make.sh test: all core packages and the completee2etestspackage pass; the remaininge2etests-clifailures are unrelated external-fixture issues (changed remote icon bytes and a Playwright 1.52 driver URL returning 404)Implementation and validation were assisted by OpenAI Codex; I reviewed the resulting diff and test output.
Fixes #1979