Repository navigation
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/release.yml" line_range="180" />
<code_context>
include:
- build: 'x64'
- os: ubuntu-22.04
+ os: ubuntu-26.04
- build: 'arm64'
- os: ubuntu-24.04-arm
</code_context>
<issue_to_address>
**Some builds still use Ubuntu 24.04**
When the migration claim is intended to cover all CI and release build paths, the UI checks, CUDA build, and OpenVINO, SYCL, and ROCm release jobs still run on Ubuntu 24.04, so those paths do not exercise Ubuntu 26.04 despite the stated migration across CI and release workflows.
Migrate the remaining jobs that are in scope to Ubuntu 26.04, or narrow the description to the workflows and targets actually migrated.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the Ubuntu runner and Docker image changes alter build behavior, and the Docker image now installs uv from Astral’s installer; if these changes produce incorrect release binaries or links, those published assets can outlive a revert but can be replaced or corrected. Most other failures would be ordinary CI failures that reverting restores.
Blocking findings: .github/workflows/release.yml:180
| - build: 's390x' | ||
| os: ubuntu-24.04-s390x | ||
| - build: '26.04-x64' | ||
| os: ubuntu-26.04 |
There was a problem hiding this comment.
🟡 Medium · Some builds still use Ubuntu 24.04
When the migration claim is intended to cover all CI and release build paths, the UI checks, CUDA build, and OpenVINO, SYCL, and ROCm release jobs still run on Ubuntu 24.04, so those paths do not exercise Ubuntu 26.04 despite the stated migration across CI and release workflows.
Migrate the remaining jobs that are in scope to Ubuntu 26.04, or narrow the description to the workflows and targets actually migrated.
Prompt for AI agents
In `.github/workflows/release.yml` at line 180:
**Some builds still use Ubuntu 24.04**
When the migration claim is intended to cover all CI and release build paths, the UI checks, CUDA build, and OpenVINO, SYCL, and ROCm release jobs still run on Ubuntu 24.04, so those paths do not exercise Ubuntu 26.04 despite the stated migration across CI and release workflows.
Migrate the remaining jobs that are in scope to Ubuntu 26.04, or narrow the description to the workflows and targets actually migrated.
* mtmd : resize Gemma 4 images without letterbox padding * Apply suggestion from @ngxson --------- Co-authored-by: Xuan-Son Nguyen <thichthat@gmail.com>
) Limit the shared prefix to the first required output position of the parent and each child task. This keeps decision output embeddings available in the final batch when questions share option tokens. Fixes ggml-org#30482 Signed-off-by: aiqubits <aiqubits@hotmail.com>
…gml-org#31406) * llama : fix rotation of layers that reuse another layer's KV cache * llama : use KV source rotation only for attn_* tensors
Assisted-by: Claude Opus 5.5
* tests : enable Gemma 4 in `test-llama-archs` * tests : use GQA for Gemma 4 in `test-llama-archs`
* hexagon : fix DMA transfers with strides > 24 bits On v75+ the 2D DMA descriptor stores row_size and strides in 24 bits. dma_queue_push sent oversized strides to fallback_2d, which only splits nrows, so strides of 16 MB or more were truncated - wrong addresses. Fix will fall back to one transfer per row in that case. Also added two CONT tests with source strides over 16 MB. * hex-dma: refactor the fallback paths to remove duplication --------- Co-authored-by: Max Krasnyansky <maxk@qti.qualcomm.com>
* opencl: add iq3_s AOS mv Assisted-by: Codex * opencl: add iq3_s SOA mv and tiled mm Assisted-by: Codex * opencl: add iq3_s noshuffle gemm/gemv for adreno Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex * opencl: add iq3_s dp4a for adreno Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex * opencl: optimize iq3_s adreno decode and narrow batches Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex * opencl: add iq3_xxs AOS mv Assisted-by: Codex * opencl: add iq3_xxs SOA mv and tiled mm Assisted-by: Codex * opencl: add iq3_xxs noshuffle gemm/gemv for adreno Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex * opencl: add iq3_xxs dp4a for adreno Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex * opencl: optimize iq3_xxs adreno decode and narrow batches Co-authored-by: Shaofei Qi <shaoqi@qti.qualcomm.com> Assisted-by: Codex --------- Co-authored-by: Li He <lih@qti.qualcomm.com>
…gth (ggml-org#31422) * webgpu: keep scratch alloc sizes monotonic in the batch length The flash attention vec path and the MMVQ path append a scratch area after dst, but get_alloc_size only accounted for it when the current batch takes that path. The size was therefore not monotonic in the batch length: a graph reserved at n_ubatch (tiled path, no scratch) or at one token did not cover batches of 2 to 19 query rows, and GGML_SCHED_NO_REALLOC builds aborted on an unexpected reallocation. Pass the row count to both path predicates and size the scratch with the row count clamped to the longest batch the short path serves. * nit: align the mmvq pipeline key with clang-format 22 * webgpu: address review @yomaytk, name the mat-vec row threshold
* Correctly gate immintrin.h inclusion when building with clang-cl and avx512bf16 * ggml : explicit vector casts for clang-cl
* jinja: implement map('filter')
* jinja : validate filter keyword arguments
Assisted-by: Codex
ggml-org#31326) * ui: don't reload a loading model on select, prefer it in pre-selection Assisted-by: Claude (Opus 5.5 Medium) * ui: skip hidden models in automatic model selection Assisted-by: Claude (Opus 5.5 Medium) * ui: don't count a model being unloaded as loading Assisted-by: Claude (Opus 5.5 Medium)
…rg#31314) * ui: show interrupted state for tool calls that never returned The chat-level streaming flag was applied to every assistant message, so a tool call left without a result in an earlier message kept spinning while a newer reply streamed. Scope streaming to the last assistant message and mark finished calls without a result as interrupted. Assisted-by: Claude (Opus 5.5 Medium) * ui: mark a shell command stopped before any output as interrupted exec_shell_command creates its result message before running, so stopping it mid-run leaves an empty result instead of none. Assisted-by: Claude (Opus 5.5 Medium)
…#31304) A message queued while a conversation was busy was re-sent through sendMessage, which targets the active conversation, so switching chats before the turn ended delivered it into the wrong one. Re-send only when the owning conversation is active; otherwise keep it queued there and flush it when that conversation is opened again. Assisted-by: Claude (Opus 5.5 Medium)
…31312) Use the popover background, softer border, rounded-xl corners and shadow-md like dropdowns, hover cards and the settings dialog, and match the dialog title line height. Assisted-by: Claude (Opus 5.5 Medium)
The router only removes models it took from the Hugging Face cache, but the models manager offered "Delete from disk" for every model, so a model from --models-preset or --models-dir failed with a "not removable" toast. Read the source and can_remove fields of /models and show the delete action disabled for those models, with a tooltip (a hint line in the mobile drawer) saying how to remove them instead. Assisted-by: Claude (Opus 5.5 Medium)
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
taronaeo
force-pushed
the
feat/ci-ubuntu-26
branch
from
November 2, 2026 12:00
66ca005 to
377966a
Compare
github-actions
Bot
added
documentation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Additional information
Requirements
Summary by Sourcery
Migrate Linux CI and release builds to Ubuntu 26.04, updating containers, toolchains, caches, and published artifact references for the new platform.
Enhancements:
Build:
Documentation: