fix(postgresql): support :: casts on parameter/variable placeholders#2664
Open
nguyenmp wants to merge 1 commit into
Open
fix(postgresql): support :: casts on parameter/variable placeholders#2664nguyenmp wants to merge 1 commit into
nguyenmp wants to merge 1 commit into
Conversation
cast_expr did not accept var_decl ( / 94104..94104 / @x placeholders) as a cast operand, so failed in function arguments, WHERE clauses, and other expression positions (it only worked at the top column level). Add var_decl to both the bare and parenthesized cast operand lists. Add round-trip tests for casts on placeholders in function args, WHERE, parenthesized form, and a nested-cast CTE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
SELECT * FROM "t" WHERE a = $1::jsonbcast_expr did not accept var_decl as a cast operand, so
$1::textfailed in function arguments, WHERE clauses, and other expression positions (it only worked at the top column level). Add var_decl to both the bare and parenthesized cast operand lists.Add round-trip tests for casts on placeholders in function args, WHERE, parenthesized form, and a nested-cast CTE.