Repository navigation
Home page: the Pre-release button downloads the release candidate for your system - #30
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying solidcraft-landing with
|
| Latest commit: |
c50793d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cea55c13.solidcraft-landing.pages.dev |
| Branch Preview URL: | https://rc-button-direct.solidcraft-landing.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the SolidCraft home page, clicking the Pre-release button now downloads the release candidate for your system, the same way the main Download button does for the stable release. Before this it only went to a list on the download page.
It's a plain link, so a download starts only on a click; the site's "never downloads by itself" tests still pass. It goes to the list when the system can't be detected or GitHub can't be reached, and the button is hidden when there's no release candidate newer than stable.
The home page now makes one more request to api.github.com for the release list, without credentials. The privacy page already covers those requests.
Tested: unit tests,
biome ci, and the browser tests, with new tests for the Windows x64 link, the fallback and the hidden case using a mocked release list. Not tested: a real download on each system.