Skip to content

Linux desktop entry: shorten launcher comment to "Parametric 3D CAD" - #17248

Merged
bherbruck merged 1 commit into
tangency-labs:mainfrom
umutacil:packaging/desktop-comment
Nov 15, 2026
Merged

bherbruck merged 1 commit into
tangency-labs:mainfrom
umutacil:packaging/desktop-comment

Conversation

@umutacil

@umutacil umutacil commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Change

Shorten the desktop entry's Comment field from "Parametric 3D CAD: sketch, constrain, extrude, and change a parameter to rebuild" to "Parametric 3D CAD".

In desktop application launchers such as KDE Plasma's Application Launcher, the previous description was unusually long and truncated mid-sentence, making it the only installed application with an entire workflow description in its launcher entry. Listing action sequences ("sketch, constrain, extrude, and change a parameter to rebuild") feels out of place for an application launcher summary and clutters the menu view. Shortening it to "Parametric 3D CAD" keeps the launcher entry clean, standard, and fully readable without clipping.

Changes a default: no

Validation

  • Verified desktop entry syntax:
    desktop-file-validate assets/platforms/linux/io.tangencylabs.solidcraft.desktop (passed, exit 0).
  • Ran packaging desktop checks from .github/workflows/packaging-lint.yml:
    • grep -qx 'StartupWMClass=io.tangencylabs.solidcraft' assets/platforms/linux/io.tangencylabs.solidcraft.desktop (passed).
    • grep -qx 'X-Flatpak-RenamedFrom=ai.storyteller.solidcraft.desktop;ai.storyteller.solvecraft.desktop;' assets/platforms/linux/io.tangencylabs.solidcraft.desktop (passed).
  • Ran python3 packaging/tests/apprun_test.py (6 tests OK, exit 0).
  • Ran cargo xtask assets and cargo xtask lists (clean, exit 0).

Screenshots of the behavior (when observable)

N/A (metadata change in desktop file).

Integration status

Branched from upstream/main at c71236a40; single clean commit with no conflicts.

Summary by CodeRabbit

  • Documentation
    • Shortened the Linux desktop entry’s description to “Parametric 3D CAD.”

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Linux desktop entry’s comment changes to “Parametric 3D CAD” from a longer description of Solidcraft’s capabilities.

Changes: Linux desktop entry

Layer / File(s) Summary
Shorten desktop entry comment
assets/platforms/linux/io.tangencylabs.solidcraft.desktop
The comment changes to “Parametric 3D CAD” and no longer mentions sketching, constraining, extruding, or rebuilding from parameter changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · up to d75ef

This only shortens the launcher description so it is no longer truncated in application launchers. It has no runtime impact and is safe to merge.

Architecture risk: Low · up to d75ef

The change affects 1 system.

Changed systems: assets

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — assets (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in assets/platforms/linux/io.tangencylabs.solidcraft.desktop: The desktop entry’s comment is shortened; it no longer mentions sketching, constraining, extruding, or rebuilding from parameter changes.
Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title states the main change: the Linux desktop entry's launcher comment is shortened to "Parametric 3D CAD". It matches the raw summary, which says the Comment changes from a detailed workflow de…
Description check Passed The description covers the required template sections. It explains what changed and why, in plain terms, and states that the change does not alter a default ("Changes a default: no"). It also gives va…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Existing Defaults Unchanged Passed The pull request changes one line in one file: the Comment field of assets/platforms/linux/io.tangencylabs.solidcraft.desktop, from a workflow description to "Parametric 3D CAD" (confirmed by the …
Full details: Title check

Explanation

The title states the main change: the Linux desktop entry's launcher comment is shortened to "Parametric 3D CAD". It matches the raw summary, which says the Comment changes from a detailed workflow description to that shorter text. The title is specific and concise.

Full details: Description check

Explanation

The description covers the required template sections. It explains what changed and why, in plain terms, and states that the change does not alter a default ("Changes a default: no"). It also gives validation steps with results. The screenshot section is marked N/A with a reason, which the template allows for changes with no useful observable behavior. The Change section does not name the project for a newcomer (it refers to "Parametric 3D CAD" and the desktop entry) and does not link an issue, which is minor. The integration status section is brief but present.

Full details: Existing Defaults Unchanged

Explanation

The pull request changes one line in one file: the Comment field of assets/platforms/linux/io.tangencylabs.solidcraft.desktop, from a workflow description to "Parametric 3D CAD" (confirmed by the git diff over the review range; the only changed file is this desktop entry). The Comment key is descriptive metadata shown in application launchers. It is not a default setting or preference value, not a command or tool behaviour when used normally, not a UI default layout or behaviour, and not a shortcut. The diff changes no runtime behaviour, so no UX default that a user relies on changes. The description's Changes a default: no is consistent with the diff. The check passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c71236a and d75efef.

Files selected for processing: 1

  • assets/platforms/linux/io.tangencylabs.solidcraft.desktop

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@bherbruck bherbruck added ready to merge reviewed, every ask addressed; merge once CI is green approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) labels Nov 15, 2026
@bherbruck
bherbruck enabled auto-merge November 15, 2026 16:37
@bherbruck
bherbruck added this pull request to the merge queue Nov 15, 2026
Merged via the queue into tangency-labs:main with commit 90accf7 Nov 15, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) ready to merge reviewed, every ask addressed; merge once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants