Repository navigation
Weldments: a Frame Member feature can name the world axis that is up, for parts drawn with Y up #15930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unusuallyhandsome
wants to merge
3
commits into
tangency-labs:main
Choose a base branch
from
Siddique-Ice:frame-member-up-axis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+274
−37
Open
Weldments: a Frame Member feature can name the world axis that is up, for parts drawn with Y up #15930
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "en": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "Up Axis" }, | ||
| "ar": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "المحور العلوي" }, | ||
| "de": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "Hochachse" }, | ||
| "he": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "ציר כלפי מעלה" }, | ||
| "ja": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "上方向の軸" }, | ||
| "ko": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "위쪽 축" }, | ||
| "vi": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "Trục hướng lên" }, | ||
| "zh": { "-X": "-X", "-Y": "-Y", "-Z": "-Z", "Up Axis": "向上轴" } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| //! A frame member saves its `up` axis when it is not world +Z: the world axis its profile's y | ||
| //! points along as far as each line allows, and the axis its vertical members run along. An | ||
| //! older design without it gets world +Z, so its members keep the axes they had. A build before | ||
| //! this change opens such a design with a newer-format warning, builds its members with Z up, | ||
| //! and keeps the field it cannot read when it saves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the
upframe, or compute it in world coordinates.The
updocumentation says the axis is a world direction.eval_frame.rsbuilds the member basis from segments in the feature's component frame, andbody_worldthen places the body with the component transform. For a component with a rotated placement,up: "Y"therefore follows the component's Y axis, not world Y. The member is then not vertical in world Y, which contradicts the documented contract atframe.rs:309-311,frame.rs:337-338, andframe.rs:789-790.The default
Zuses the same path. Changing the basis to world coordinates for every up axis would also change defaultZresults on rotated components.frame-member-up.rsstates that older designs keep their existing axes, so that change needs a separate decision.Choose one of these:
UpAxisandmember_axesdocs to say the axis is in the component frame.upinto the segment frame with the inverse of the component's rotation. Before doing this, check that defaultZresults on rotated components stay unchanged.