Repository navigation
Sheet metal: an edge-flange segment can ask for a bend relief at its junction, cut in the flat pattern and the DXF (#5942) #15357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lychee888
wants to merge
16
commits into
tangency-labs:main
Choose a base branch
from
lychee888:fr13-junction-relief
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,580
−45
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
caa7ab7
FR-13 WIP: per-junction relief, recovered after the engineer worker c…
lychee888 1d7b34e
FR-13: the DXF notch assertion checks the three lines the outline dra…
lychee888 61a180e
FR-13: the relief choice shares the turns row so a four-stretch edge …
lychee888 08ac26e
FR-13: collapse the relief guard and take rustfmt's layout
lychee888 63a06f3
FR-13: a junction relief cuts the panel that holds it, a same-side te…
lychee888 6280f63
FR-13: a relief that reaches the edge inboard of the junction refuses…
lychee888 91c2952
FR-13: only a blank's own edge parts it; a flange panel's edge is a b…
lychee888 3d04afe
FR-13: a tear parts the blank only where no material lies beyond its …
lychee888 19bff62
FR-13: a tear's deep end is measured against every edge of the flat m…
lychee888 c2c6e89
FR-13: a tear refuses only when its slit ends on the edge it already …
lychee888 c7fdbe5
FR-13: the curve fallback walks at 1e-7 mm, below the slit's decision…
lychee888 96f5999
FR-13: the tear guard settles its question with bounded intervals and…
lychee888 f980d08
FR-13: the tear guard asks the kernel whether the slit parts the blank
lychee888 f22d4f8
FR-13: the tear guard probes every slit in the design together
lychee888 f35d530
FR-13: a flange feature may not leave the blank in more pieces than i…
lychee888 12e923c
FR-13: pair a junction by its source edge, carry a relief through mir…
lychee888 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "en": { | ||
| "Relief": "Relief", | ||
| "Straight": "Straight", | ||
| "Obround": "Obround" | ||
| }, | ||
| "ar": { | ||
| "Relief": "التخفيف", | ||
| "Straight": "مستقيم", | ||
| "Obround": "مستدير الأطراف" | ||
| }, | ||
| "he": { | ||
| "Relief": "הקלה", | ||
| "Straight": "ישר", | ||
| "Obround": "סגלגל" | ||
| }, | ||
| "ja": { | ||
| "Relief": "逃げ", | ||
| "Straight": "直線", | ||
| "Obround": "長円" | ||
| }, | ||
| "vi": { | ||
| "Relief": "Rãnh giảm ứng suất", | ||
| "Straight": "Thẳng", | ||
| "Obround": "Bầu dục" | ||
| }, | ||
| "zh": { | ||
| "Relief": "让位", | ||
| "Straight": "直线", | ||
| "Obround": "长圆" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| //! An edge flange's segment saves `relief` (`{shape, width?, depth?}`) when `sheet.flange` was | ||
| //! asked to relieve the junction the segment ends at: the shape (`straight`, `rectangular`, | ||
| //! `obround`, `tear` or `notch`), and its width and depth where the segment named its own. | ||
| //! Absent, no relief is cut and the junction builds exactly as designs before this change were | ||
| //! built, so an older design has no key and needs no rewrite. The last release refuses a design | ||
| //! with this change (the newer format number). |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the pending attribution entry for the new locale file.
The PR adds a new file under
assets/locales/pending/. The repository requires an attribution row for each new asset. New UI strings also need their attribution row inattribution/pending/<slug>.md. Noattribution/pending/junction-relief.mdexists in the checkout. Without that row,cargo xtask assetsfails, andcargo xtask cicannot pass.Add
attribution/pending/junction-relief.mdwith the required row forassets/locales/pending/junction-relief.json.Source: Coding guidelines