Repository navigation
solidcore: keep a variable round's skin only on a bound over each span against its interpolated ball family (#15256) #15257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
brett19
wants to merge
8
commits into
tangency-labs:main
from
brett19:blend/variable-round-skin-stations
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
42aa45c
solidcore: claim: hold a variable round's skin to its tolerance betwe…
brett19 bfd38cc
solidcore: a variable round holds its skin to its tolerance between s…
brett19 5712c27
solidcore: skip a law-corner round's definition nets in the skin test…
brett19 fab7b5a
solidcore: measure a law-corner round's pieces, and place a skin stat…
brett19 3b97f9b
solidcore: prove the moved law rounds against their balls in closed f…
brett19 fbaf7e2
solidcore: type the skin check's refusals, and split a span whose sec…
brett19 4f6d5ed
solidcore: keep a variable round's span only on a proved bound over t…
brett19 4f20c56
solidcore: expectations: six law rounds' goldens move; wr646 holds it…
brett19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 6 additions & 6 deletions
12
solidcore/crates/goldens/expected/blend.fillet_executive_p3.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,489 changes: 1,405 additions & 84 deletions
1,489
solidcore/crates/solidcore/src/blend/fillet_intersector.rs
Large diffs are not rendered by default.
Oops, something went wrong.
1,102 changes: 1,102 additions & 0 deletions
1,102
solidcore/crates/solidcore/src/blend/fillet_intersector/skin_bound.rs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not accept a varying-ball B-spline skin on sampled midpoint checks alone.
The refinement path in
flush_curvecan accept a non-definition B-spline skin. Its acceptance rests on nine sampled points per span, and the code's own doc says this "certifies nothing." A span can pass those samples and still leave the skin farther than the tolerance from the balls' envelope between the sampled points. The project contract requires every face of a result to be exact or certified against its definition, and a sampled check is not a certificate.Keep the refinement as a construction aid, but require a stored enclosure before a B-spline skin is accepted. If no enclosure can be built, refuse the round with a typed error. This matches the existing refusal pattern for uncertifiable constructions. Do not raise the tolerance.
Source: Coding guidelines
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on the facts: the midpoint check is sampled and certifies nothing. This PR does not claim it does. I am keeping it as a refinement heuristic instead of requiring a stored enclosure, for these reasons.
skin_splitsonly decides where to add stations, so it can only move the skin toward its balls. Its doc and the module header now say it is a refinement heuristic, not a certificate (docs/definitions-and-certificates.md§7.6, "No sampled certificate"). Nothing stores an ε from it, sets a certified flag, or answers a final question from it.certify_the_moved_rows_skins_within_t.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 38501
@brett19Thanks for the clarification. I agree thatskin_splitsis a refinement heuristic, not a claimed certificate. My comment should have made that distinction clear.The remaining gap is the returned face. The face contract in
solidcore/docs/definitions-and-certificates.md, also reflected in the retrieved review guidance, requires an exact face or a certified net. The reported offline proof covers six rows, not arbitrary runtime inputs. I did not run the proof test.I understand your decision to defer the certified construction to
#15657. I am not marking this finding as addressed.Learnings used
You are interacting with an AI system.