You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
solidcore: shelling the issue_1476 swept bar fails with offset_keep_cavity_regions on (point-solve geometry owners) #17393
With UpstreamFixes::offset_keep_cavity_regions (WR-667) on, the swept-bar shell from solidcore/crates/solidcore/tests/issue_1476_swept_bar_shell.rs fails. SolidCraft's preset (crates/smlib/src/core.rsfixes()) turns this flag on. Without the flag, the same shell builds a solid of the closed-form volume.
Observed error:
Unsupported { operation: "offset::offset_executive::p1", reason: "point-solve geometry owners must identify one edge or face each" }
The fixes() copy in that test file is out of date: it lists 46 flags, the preset 154. It does not include offset_keep_cavity_regions, so the test suite never runs this combination.
Add these tests to solidcore/crates/solidcore/tests/issue_1476_swept_bar_shell.rs. They reuse its shell() helper: SmApiShellBrepFull, -0.5 inward, open at the start cap, extended convex edges, merged results, offset solid made.
Run with cargo test --profile goldens -p solidcore --test issue_1476_swept_bar_shell -- --nocapture.
fixes
result
Kernel::default()
Ok, the solid the test checks against the closed form
default + offset_keep_cavity_regions
Err, the error above
SolidCraft's full core::fixes() preset (all 154 lines copied)
Err, the same error
that preset with offset_keep_cavity_regions = false
Ok, 27 faces
According to PR #17325, the error comes from the cavity test's make_original_brep_cache.
Expected
The shell builds the solid with V = 40 L - 28 (L - 0.5), where L = 60 + 15π, as it does with the flag off. SolidCraft may hit this on swept-shell features, because its preset has the flag on. This blocks retiring offset_keep_cavity_regions under #14246.
Written by Claude Code (Anthropic) on behalf of @brett19.
Activity
github-actions commentedon Nov 15, 2026
Claimed by @brett19 through #17452. The claim lapses after 14 days without pushes.
solidcore: keep issue_1476 and issue_1950 on the operands their pins …
solidcore: tests use the one fixes preset instead of copied flag list…
solidcore: tests use the one fixes preset instead of copied flag lists (
solidcore: Shell keeps cavity regions without ambiguous point-solve o…