Skip to content

solidcore: retire the remaining UpstreamFixes flags, in batches #14246

Open

Description

@brett19

solidcore/AGENTS.md §4b says the existing UpstreamFixes flags are retired. This issue tracks retiring the remaining ones in small batches, one PR per batch. Each PR deletes the field, the code path the flag turned off, its preset line in crates/smlib/src/core.rs, its fixes.json entry and the tests' "off" halves.

Builds on tdamsma's reachability audit (#13843), which used an earlier preset and test set.

Survey (2026-11-09, origin/main b653486)

Full report and one CSV row per flag: https://gist.github.com/brett19/18a1b63a4f7e7a8419669769003b79bd

Method:

  • Every library read of a flag was instrumented (1137 reads).
  • Each flag was measured as the default kernel plus that one flag, over the goldens cases that reach it (3502 capped unit runs).
  • The kernel rig was run with fixes.json and with []. For each of the 130 cases that fail without flags, a ddmin found the minimal set of flags it needs.
group flags meaning
A 86 no golden case and no rig case changes (5 of them are read nowhere)
B 170 values move, nothing regresses; each moved row is blessed with a reason
C 30 some rows regress; each needs judgement
D 1 HELD_BACK (fillet_round_ends_on_outline)
E 18 already retired or in an open PR

Things to know before retiring:

Batches

Order: A (by area), then B17/B18, then B by area, then C. A batch never touches a flag claimed by an open PR. Each PR runs the full goldens and the kernel rig.

Changes a default: no

Activity

  1. github-actions commented on Nov 10, 2026

    @github-actions
    Contributor

    Claimed by @austin62jake through #14679. The claim lapses after 14 days without pushes.

  2. austin62jake commented on Nov 10, 2026

    @austin62jake
    Contributor

    A16 (topology) is in draft #14679: loop_orientation_floor_from_loop_box, trim_boundary_seam_wrap, imprint_extension_keeps_analytic_curve, shell_inner_shell_of_statuses and is_iso_curve_at_propagates_canonical_failure.

    Already done on main, from checking that each batch's flags still exist at 87400c80e: A4, A5, A6, A7, A8, A11, A12 and A14 have no flags left.

    Written by Claude Code (Anthropic) on behalf of @austin62jake.

  3. 301 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in progresssomeone is working on it (see comments)needs-triageno priority yet; a maintainer sorts it with /triage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions