Skip to content

Refactored Check-in - #336

Merged
tancheng merged 55 commits into
masterfrom
codex/master-register-bank-798aaf5
Sep 12, 2026
Merged

tancheng merged 55 commits into
masterfrom
codex/master-register-bank-798aaf5

Conversation

@Jackcuii

Copy link
Copy Markdown
Collaborator

No description provided.

Jackcuii and others added 30 commits March 29, 2026 09:05
- Add CgraRTL_relu4x4_test_from_yaml.py: ReLU kernel test on 4x4 Mesh CGRA
  using relu.yaml compiled kernel config (II=5, 32 iterations)
- Fix script_generator.py: swap STORE src_operands to match MemUnitRTL
  hardware expectation (in0=address, in1=data vs YAML order [data, addr])
…flag

Bug #1 - CrossbarRTL all-or-nothing: Stale prologued data blocked entire crossbar
- Mask recv_valid_vector, exclude prologued from send/recv_required_vector
- Gate changed: recv_valid_or_prologue_allowing_vector

Bug #2 - PhiRTL shared first flag: Multiple PHI_START on same tile failed
- Detect iteration wrap via ctrl_addr, clear s.first only at boundaries
- Added prev_ctrl_addr tracking

Tests: ReLU 379 cycles (pass), SpMV 759 cycles (pass)
Comment thread fu/single/test/CompRTL_test.py
Comment thread fu/single/PhiRTL.py
Comment thread lib/util/data_struct_attr.py Outdated
Co-authored-by: Jackcuii <113412207+Jackcuii@users.noreply.github.com>
Co-authored-by: Jackcuii <113412207+Jackcuii@users.noreply.github.com>
@Jackcuii

Jackcuii commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Sir Tan @tancheng I think it is ok ~ Let us wait for the tests. Please check if there are anything else we need to modify 🤓

@tancheng
tancheng merged commit c9b200f into master Sep 12, 2026
2 checks passed
@Jackcuii

Copy link
Copy Markdown
Collaborator Author

Hi Sir Tan @tancheng I think it is ok ~ Let us wait for the tests. Please check if there are anything else we need to modify 🤓

Thank you Sir Tan~ Finally we merge it hahaha

@tancheng

Copy link
Copy Markdown
Owner

Hi Sir Tan @tancheng I think it is ok ~ Let us wait for the tests. Please check if there are anything else we need to modify 🤓

Thank you Sir Tan~ Finally we merge it hahaha

Thank you Bohan @Jackcuii~! Plz make another PR that only contains the register-related changes, so we can check-in the missing test (I forgot which one is still blocked by the register-related fixes).

@Jackcuii

Copy link
Copy Markdown
Collaborator Author

Hi Sir Tan @tancheng I think it is ok ~ Let us wait for the tests. Please check if there are anything else we need to modify 🤓

Thank you Sir Tan~ Finally we merge it hahaha

Thank you Bohan @Jackcuii~! Plz make another PR that only contains the register-related changes, so we can check-in the missing test (I forgot which one is still blocked by the register-related fixes).

Sure! I think the blocked ones are gemm and gemv. I need first identify the root cause of the diff ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants